Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9033)

Unified Diff: chrome/browser/ui/views/apps/chrome_native_app_window_views_aura_ash.cc

Issue 2700523004: Remove docked windows entirely in M59. (Closed)
Patch Set: Rebase and fix 1 test Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/apps/chrome_native_app_window_views_aura_ash.cc
diff --git a/chrome/browser/ui/views/apps/chrome_native_app_window_views_aura_ash.cc b/chrome/browser/ui/views/apps/chrome_native_app_window_views_aura_ash.cc
index 65e254eb468daea8636b16878902bd6f4e891609..86a08fb80b5ccb0ecd5efda20653c125c91b77e2 100644
--- a/chrome/browser/ui/views/apps/chrome_native_app_window_views_aura_ash.cc
+++ b/chrome/browser/ui/views/apps/chrome_native_app_window_views_aura_ash.cc
@@ -131,14 +131,6 @@ void ChromeNativeAppWindowViewsAuraAsh::InitializeWindow(
const AppWindow::CreateParams& create_params) {
ChromeNativeAppWindowViewsAura::InitializeWindow(app_window, create_params);
aura::Window* window = widget()->GetNativeWindow();
-
- // TODO(afakhry): Remove Docked Windows in M58.
- // Restore docked state on ash desktop if the docked windows flag is enabled.
- if (create_params.state == ui::SHOW_STATE_DOCKED &&
- ash::switches::DockedWindowsEnabled()) {
- window->SetProperty(aura::client::kShowStateKey, create_params.state);
- }
-
window->SetProperty(aura::client::kAppIdKey,
new std::string(app_window->extension_id()));
@@ -253,16 +245,6 @@ ChromeNativeAppWindowViewsAuraAsh::GetRestoredState() const {
}
return ui::SHOW_STATE_FULLSCREEN;
}
-
- // TODO(afakhry): Remove Docked Windows in M58.
- if (ash::switches::DockedWindowsEnabled() &&
- (widget()->GetNativeWindow()->GetProperty(
- aura::client::kShowStateKey) == ui::SHOW_STATE_DOCKED ||
- widget()->GetNativeWindow()->GetProperty(
- aura::client::kPreMinimizedShowStateKey) ==
- ui::SHOW_STATE_DOCKED)) {
- return ui::SHOW_STATE_DOCKED;
- }
}
return GetRestorableState(restore_state);

Powered by Google App Engine
This is Rietveld 408576698