Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Unified Diff: ash/metrics/user_metrics_recorder.cc

Issue 2700523004: Remove docked windows entirely in M59. (Closed)
Patch Set: Rebase and fix 1 test Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ash/metrics/user_metrics_recorder.cc
diff --git a/ash/metrics/user_metrics_recorder.cc b/ash/metrics/user_metrics_recorder.cc
index 414ce2f5afa319e47334524adbd9b8c042769e24..093ff05048ce8cea3dc7e104e328f04cc4fac861 100644
--- a/ash/metrics/user_metrics_recorder.cc
+++ b/ash/metrics/user_metrics_recorder.cc
@@ -37,7 +37,6 @@ enum ActiveWindowStateType {
ACTIVE_WINDOW_STATE_TYPE_MAXIMIZED,
ACTIVE_WINDOW_STATE_TYPE_FULLSCREEN,
ACTIVE_WINDOW_STATE_TYPE_SNAPPED,
- ACTIVE_WINDOW_STATE_TYPE_DOCKED,
ACTIVE_WINDOW_STATE_TYPE_PINNED,
ACTIVE_WINDOW_STATE_TYPE_TRUSTED_PINNED,
ACTIVE_WINDOW_STATE_TYPE_COUNT,
@@ -59,10 +58,6 @@ ActiveWindowStateType GetActiveWindowState() {
case wm::WINDOW_STATE_TYPE_RIGHT_SNAPPED:
active_window_state_type = ACTIVE_WINDOW_STATE_TYPE_SNAPPED;
break;
- case wm::WINDOW_STATE_TYPE_DOCKED:
- case wm::WINDOW_STATE_TYPE_DOCKED_MINIMIZED:
- active_window_state_type = ACTIVE_WINDOW_STATE_TYPE_DOCKED;
- break;
case wm::WINDOW_STATE_TYPE_PINNED:
active_window_state_type = ACTIVE_WINDOW_STATE_TYPE_PINNED;
break;
@@ -119,9 +114,9 @@ bool IsUserActive() {
// UMA statistics. Note the containers are ordered from top most visible
// container to the lowest to allow the |GetNumVisibleWindows| method to short
// circuit when processing a maximized or fullscreen window.
-int kVisibleWindowContainerIds[] = {
- kShellWindowId_PanelContainer, kShellWindowId_DockedContainer,
- kShellWindowId_AlwaysOnTopContainer, kShellWindowId_DefaultContainer};
+int kVisibleWindowContainerIds[] = {kShellWindowId_PanelContainer,
oshima 2017/02/22 06:49:07 nit: space betwee { and kShel...
afakhry 2017/02/22 22:04:43 Done. I don't know why git cl format produces this
+ kShellWindowId_AlwaysOnTopContainer,
+ kShellWindowId_DefaultContainer};
// Returns an approximate count of how many windows are currently visible in the
// primary root window.

Powered by Google App Engine
This is Rietveld 408576698