chrome/browser/extensions/api/sessions/sessions_api.cc - Issue 2700523004: Remove docked windows entirely in M59.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/sessions/sessions_api.cc

Issue 2700523004: Remove docked windows entirely in M59. (Closed)

Patch Set: Use panel in test Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/extensions/api/sessions/sessions_api.cc

diff --git a/chrome/browser/extensions/api/sessions/sessions_api.cc b/chrome/browser/extensions/api/sessions/sessions_api.cc

index 8d2cbdadadf08fefdfdd12ef041acfb8bb007763..e5dcba164b9e971f77850a4c6def2f20c84fffa4 100644

--- a/chrome/browser/extensions/api/sessions/sessions_api.cc

+++ b/chrome/browser/extensions/api/sessions/sessions_api.cc

@@ -275,9 +275,6 @@ std::unique_ptr<windows::Window> SessionsGetDevicesFunction::CreateWindowModel(

windows::WindowState state = windows::WINDOW_STATE_NONE;

switch (window.show_state) {

case ui::SHOW_STATE_NORMAL:

- // TODO(afakhry): Remove Docked Windows in M58.

- case ui::SHOW_STATE_DOCKED:

state = windows::WINDOW_STATE_NORMAL;

break;

case ui::SHOW_STATE_MINIMIZED: