Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(734)

Side by Side Diff: chrome/browser/extensions/api/sessions/sessions_api.cc

Issue 2700523004: Remove docked windows entirely in M59. (Closed)
Patch Set: Rebase Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/browser/about_flags.cc ('k') | chrome/browser/media/webrtc/desktop_media_list_ash.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/extensions/api/sessions/sessions_api.h" 5 #include "chrome/browser/extensions/api/sessions/sessions_api.h"
6 6
7 #include <stddef.h> 7 #include <stddef.h>
8 8
9 #include <utility> 9 #include <utility>
10 #include <vector> 10 #include <vector>
(...skipping 257 matching lines...) Expand 10 before | Expand all | Expand 10 after
268 type = windows::WINDOW_TYPE_NORMAL; 268 type = windows::WINDOW_TYPE_NORMAL;
269 break; 269 break;
270 case sessions::SessionWindow::TYPE_POPUP: 270 case sessions::SessionWindow::TYPE_POPUP:
271 type = windows::WINDOW_TYPE_POPUP; 271 type = windows::WINDOW_TYPE_POPUP;
272 break; 272 break;
273 } 273 }
274 274
275 windows::WindowState state = windows::WINDOW_STATE_NONE; 275 windows::WindowState state = windows::WINDOW_STATE_NONE;
276 switch (window.show_state) { 276 switch (window.show_state) {
277 case ui::SHOW_STATE_NORMAL: 277 case ui::SHOW_STATE_NORMAL:
278
279 // TODO(afakhry): Remove Docked Windows in M58.
280 case ui::SHOW_STATE_DOCKED:
281 state = windows::WINDOW_STATE_NORMAL; 278 state = windows::WINDOW_STATE_NORMAL;
282 break; 279 break;
283 case ui::SHOW_STATE_MINIMIZED: 280 case ui::SHOW_STATE_MINIMIZED:
284 state = windows::WINDOW_STATE_MINIMIZED; 281 state = windows::WINDOW_STATE_MINIMIZED;
285 break; 282 break;
286 case ui::SHOW_STATE_MAXIMIZED: 283 case ui::SHOW_STATE_MAXIMIZED:
287 state = windows::WINDOW_STATE_MAXIMIZED; 284 state = windows::WINDOW_STATE_MAXIMIZED;
288 break; 285 break;
289 case ui::SHOW_STATE_FULLSCREEN: 286 case ui::SHOW_STATE_FULLSCREEN:
290 state = windows::WINDOW_STATE_FULLSCREEN; 287 state = windows::WINDOW_STATE_FULLSCREEN;
(...skipping 314 matching lines...) Expand 10 before | Expand all | Expand 10 after
605 return g_factory.Pointer(); 602 return g_factory.Pointer();
606 } 603 }
607 604
608 void SessionsAPI::OnListenerAdded(const EventListenerInfo& details) { 605 void SessionsAPI::OnListenerAdded(const EventListenerInfo& details) {
609 sessions_event_router_.reset( 606 sessions_event_router_.reset(
610 new SessionsEventRouter(Profile::FromBrowserContext(browser_context_))); 607 new SessionsEventRouter(Profile::FromBrowserContext(browser_context_)));
611 EventRouter::Get(browser_context_)->UnregisterObserver(this); 608 EventRouter::Get(browser_context_)->UnregisterObserver(this);
612 } 609 }
613 610
614 } // namespace extensions 611 } // namespace extensions
OLDNEW
« no previous file with comments | « chrome/browser/about_flags.cc ('k') | chrome/browser/media/webrtc/desktop_media_list_ash.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698