Remove docked windows entirely in M59.

chrome/browser/ui/views/apps/chrome_native_app_window_views.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/views/apps/chrome_native_app_window_views.h"
 
 #include <stddef.h>
 #include <utility>
 
 #include "apps/ui/views/app_window_frame_view.h"
@@ skipping 196 matching lines @@
   if (preferred_size_.width() == 0)
     preferred_size_.set_width(kDefaultPanelWidth);
   else if (preferred_size_.width() < kMinPanelWidth)
     preferred_size_.set_width(kMinPanelWidth);
 
   if (preferred_size_.height() == 0)
     preferred_size_.set_height(kDefaultPanelHeight);
   else if (preferred_size_.height() < kMinPanelHeight)
     preferred_size_.set_height(kMinPanelHeight);
 
-  // When a panel is not docked it will be placed at a default origin in the
-  // currently active target root window.
-  // TODO(afakhry): Remove Docked Windows in M58.
-  bool use_default_bounds = create_params.state != ui::SHOW_STATE_DOCKED;
-  // Sanitize initial origin reseting it in case it was not specified.
-  using BoundsSpecification = AppWindow::BoundsSpecification;
-  bool position_specified =
-      initial_window_bounds.x() != BoundsSpecification::kUnspecifiedPosition &&
-      initial_window_bounds.y() != BoundsSpecification::kUnspecifiedPosition;
-  params.bounds = (use_default_bounds || !position_specified) ?
-      gfx::Rect(preferred_size_) :
-      gfx::Rect(initial_window_bounds.origin(), preferred_size_);
-  OnBeforePanelWidgetInit(use_default_bounds, &params, widget());
+  // A panel will be placed at a default origin in the currently active target
+  // root window.
+  params.bounds = gfx::Rect(preferred_size_);
+  OnBeforePanelWidgetInit(true /* use_default_bounds */, &params, widget());

[varkha, 2017/02/28 01:32:22]

Do we still need the use_default_bounds parameter for OnBeforePanelWidgetInit()?
I think it was introduced only for docking support here -
https://codereview.chromium.org/1056793006.

[afakhry, 2017/03/09 22:28:27]

No, I don't think we still need that. I removed it.

   widget()->Init(params);
   widget()->set_focus_on_creation(create_params.focused);
 }
 
 views::NonClientFrameView*
 ChromeNativeAppWindowViews::CreateStandardDesktopAppFrame() {
   return views::WidgetDelegateView::CreateNonClientFrameView(widget());
 }
 
 // ui::BaseWindow implementation.
@@ skipping 135 matching lines @@
     InitializePanelWindow(create_params);
   } else {
     InitializeDefaultWindow(create_params);
   }
   extension_keybinding_registry_.reset(new ExtensionKeybindingRegistryViews(
       Profile::FromBrowserContext(app_window->browser_context()),
       widget()->GetFocusManager(),
       extensions::ExtensionKeybindingRegistry::PLATFORM_APPS_ONLY,
       NULL));
 }