Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6536)

Unified Diff: chrome/browser/ui/views/apps/app_info_dialog/app_info_dialog_views.h

Issue 2700523002: arc: Fix crash on accessing app info for secondary user. (Closed)
Patch Set: clean up Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/apps/app_info_dialog/app_info_dialog_views.h
diff --git a/chrome/browser/ui/views/apps/app_info_dialog/app_info_dialog_views.h b/chrome/browser/ui/views/apps/app_info_dialog/app_info_dialog_views.h
index add262f22dec0e86d2c641a45c908807c5b45338..2f412d89fc20ee74013649ea9cfefc699178bdf2 100644
--- a/chrome/browser/ui/views/apps/app_info_dialog/app_info_dialog_views.h
+++ b/chrome/browser/ui/views/apps/app_info_dialog/app_info_dialog_views.h
@@ -37,6 +37,7 @@ class AppInfoDialog : public views::View,
private:
FRIEND_TEST_ALL_PREFIXES(AppInfoDialogAshTest,
PinButtonsAreFocusedAfterPinUnpin);
+ FRIEND_TEST_ALL_PREFIXES(AppInfoDialogViewsTest, ArcAppInfoLinks);
// Closes the dialog.
void Close();
@@ -51,13 +52,14 @@ class AppInfoDialog : public views::View,
void OnShutdown(extensions::ExtensionRegistry* registry) override;
// UI elements of the dialog.
- views::View* dialog_header_;
- views::ScrollView* dialog_body_;
- views::View* dialog_footer_;
+ views::View* dialog_header_ = nullptr;
+ views::ScrollView* dialog_body_ = nullptr;
+ views::View* dialog_footer_ = nullptr;
+ views::View* arc_app_info_links_ = nullptr;
Profile* profile_;
std::string app_id_;
- extensions::ExtensionRegistry* extension_registry_;
+ extensions::ExtensionRegistry* extension_registry_ = nullptr;
DISALLOW_COPY_AND_ASSIGN(AppInfoDialog);
};

Powered by Google App Engine
This is Rietveld 408576698