IDL compiler: [Reflect] for getters (+ remove unnecessary WebCore::)

IDL compiler: [Reflect] for getters

A pretty complicated one, with *lots* of special cases,
but managed to make it pretty simple.
(There's some additional special handling for SVG that
we're skipping for now.)

Doc:
https://sites.google.com/a/chromium.org/dev/blink/webidl/blink-idl-extended-attributes#TOC-Reflect-a-

BUG=239771
NOTRY=true
R=haraken@chromium.org

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=159738

[Nils Barth (inactive), 2013-10-15 02:04:13]

*ping* PTAL, thank!

[Nils Barth (inactive), 2013-10-15 02:04:14]

*ping* PTAL, thank!

[haraken, 2013-10-15 02:14:30]

Sorry for being late. LGTM.

https://codereview.chromium.org/27003002/diff/1/Source/bindings/scripts/unsta...
File Source/bindings/scripts/unstable/v8_attributes.py (right):

https://codereview.chromium.org/27003002/diff/1/Source/bindings/scripts/unsta...
Source/bindings/scripts/unstable/v8_attributes.py:153:
CONTENT_ATTRIBUTE_GETTER_NAMES = {

I don't fully understand what "content" means.

CONTENT_ATTRIBUTE_GETTER_NAMES => CPP_ATTRIBUTE_GETTER_NAMES ?

https://codereview.chromium.org/27003002/diff/1/Source/bindings/scripts/unsta...
Source/bindings/scripts/unstable/v8_attributes.py:160: def
content_attribute_getter_base_name(attribute, includes, arguments):

content_attribute_getter_base_name => cpp_attribute_getter_name ?

https://codereview.chromium.org/27003002/diff/1/Source/bindings/scripts/unsta...
Source/bindings/scripts/unstable/v8_attributes.py:162: content_attribute_name =
attribute.extended_attributes['Reflect'] or default_content_attribute_name

Nit: default_content_attribute_name is not necessary.

https://codereview.chromium.org/27003002/diff/1/Source/bindings/scripts/unsta...
Source/bindings/scripts/unstable/v8_attributes.py:167: if content_attribute_name
in ['class', 'id', 'name']:

Add a comment:

  # For performance optimization.

https://codereview.chromium.org/27003002/diff/1/Source/bindings/scripts/unsta...
Source/bindings/scripts/unstable/v8_attributes.py:170: scoped_name =
'WebCore::%s::%sAttr' % (namespace, content_attribute_name)

Is WebCore:: necessary?

[Nils Barth (inactive), 2013-10-15 09:48:14]

Thanks, replies; will commit once [NotEnumerable] lands
* "content attribute" is from the spec
* WebCore:: looks unnecessary, removing here and in Perl

https://codereview.chromium.org/27003002/diff/1/Source/bindings/scripts/unsta...
File Source/bindings/scripts/unstable/v8_attributes.py (right):

https://codereview.chromium.org/27003002/diff/1/Source/bindings/scripts/unsta...
Source/bindings/scripts/unstable/v8_attributes.py:153:
CONTENT_ATTRIBUTE_GETTER_NAMES = {
On 2013/10/15 02:14:30, haraken wrote:
> I don't fully understand what "content" means.

The IDL attribute is reflecting an HTML attribute ("content attribute"), so the
getter is a getter for the underlying content attribute.

Sorry, forgot to link to docs:
https://sites.google.com/a/chromium.org/dev/blink/webidl/blink-idl-extended-a...
http://www.whatwg.org/specs/web-apps/current-work/multipage/common-dom-interf...

"Some IDL attributes are defined to reflect a particular content attribute."

"Content attribute" is a term in the HTML5 spec (WhatWG), meaning "HTML
attribute, not IDL attribute":
http://www.whatwg.org/specs/web-apps/current-work/multipage/infrastructure.ht...
"This specification refers to both HTML and XML attributes and IDL attributes,
often in the same context. When it is not clear which is being referred to, they
are referred to as content attributes for HTML and XML attributes, and IDL
attributes for those defined on IDL interfaces."

https://codereview.chromium.org/27003002/diff/1/Source/bindings/scripts/unsta...
Source/bindings/scripts/unstable/v8_attributes.py:162: content_attribute_name =
attribute.extended_attributes['Reflect'] or default_content_attribute_name
On 2013/10/15 02:14:30, haraken wrote:
> Nit: default_content_attribute_name is not necessary.

Removed.

https://codereview.chromium.org/27003002/diff/1/Source/bindings/scripts/unsta...
Source/bindings/scripts/unstable/v8_attributes.py:167: if content_attribute_name
in ['class', 'id', 'name']:
On 2013/10/15 02:14:30, haraken wrote:
> 
> Add a comment:
> 
>   # For performance optimization.

Done.

https://codereview.chromium.org/27003002/diff/1/Source/bindings/scripts/unsta...
Source/bindings/scripts/unstable/v8_attributes.py:170: scoped_name =
'WebCore::%s::%sAttr' % (namespace, content_attribute_name)
On 2013/10/15 02:14:30, haraken wrote:
> Is WebCore:: necessary?

Doesn't look like it!
Removed here and in Perl.

[haraken, 2013-10-15 10:20:04]

Thanks for the update. LGTM.

[commit-bot: I haz the power, 2013-10-16 03:08:05]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/nbarth@chromium.org/27003002/13001

[Nils Barth (inactive), 2013-10-16 09:50:08]

Committed patchset #4 manually as r159738 (presubmit successful).