third_party/WebKit/Source/devtools/front_end/sources/EventListenerBreakpointsSidebarPane.js - Issue 2700293002: DevTools: do not use RAII for sync native breakpoints, reuse AsyncTask where possible.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/sources/EventListenerBreakpointsSidebarPane.js

Issue 2700293002: DevTools: do not use RAII for sync native breakpoints, reuse AsyncTask where possible. (Closed)

Patch Set: Introduce progress monitor Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/loader/DocumentLoader.cpp ('K') | « third_party/WebKit/Source/core/loader/DocumentLoader.cpp ('k') | third_party/WebKit/Source/modules/geolocation/Geolocation.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/sources/EventListenerBreakpointsSidebarPane.js

diff --git a/third_party/WebKit/Source/devtools/front_end/sources/EventListenerBreakpointsSidebarPane.js b/third_party/WebKit/Source/devtools/front_end/sources/EventListenerBreakpointsSidebarPane.js

index 92761c6e28f398b04dcd0ecad16cd9081a7ef6f7..71c1b5ead1e010f2558c00c335fae56bfbc37a8c 100644

--- a/third_party/WebKit/Source/devtools/front_end/sources/EventListenerBreakpointsSidebarPane.js

+++ b/third_party/WebKit/Source/devtools/front_end/sources/EventListenerBreakpointsSidebarPane.js

@@ -64,7 +64,7 @@ Sources.EventListenerBreakpointsSidebarPane = class extends UI.VBox {

'pointercancel', 'gotpointercapture', 'lostpointercapture'

]);

this._createCategory(Common.UIString('Script'), ['scriptFirstStatement', 'scriptBlockedByCSP'], true);

- this._createCategory(Common.UIString('Timer'), ['setTimer', 'clearTimer', 'timerFired'], true);

+ this._createCategory(Common.UIString('Timer'), ['setTimeout', 'clearTimeout', 'timerFired'], true);

caseq 2017/02/21 21:04:27 should it also mention interval?

this._createCategory(Common.UIString('Touch'), ['touchstart', 'touchmove', 'touchend', 'touchcancel']);

this._createCategory(Common.UIString('Window'), ['DOMWindow.close'], true);

this._createCategory(

@@ -86,8 +86,8 @@ Sources.EventListenerBreakpointsSidebarPane = class extends UI.VBox {

static eventNameForUI(eventName, auxData) {

if (!Sources.EventListenerBreakpointsSidebarPane._eventNamesForUI) {

Sources.EventListenerBreakpointsSidebarPane._eventNamesForUI = {

- 'instrumentation:setTimer': Common.UIString('Set Timer'),

- 'instrumentation:clearTimer': Common.UIString('Clear Timer'),

+ 'instrumentation:setTimeout': Common.UIString('Set Timer'),

+ 'instrumentation:clearTimeout': Common.UIString('Clear Timer'),

'instrumentation:timerFired': Common.UIString('Timer Fired'),

'instrumentation:scriptFirstStatement': Common.UIString('Script First Statement'),

'instrumentation:scriptBlockedByCSP': Common.UIString('Script Blocked by Content Security Policy'),