Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(264)

Unified Diff: third_party/WebKit/Source/devtools/front_end/sources/EventListenerBreakpointsSidebarPane.js

Issue 2700263003: DevTools: normalize native breakpoint names. (Closed)
Patch Set: fixed the test Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/sources/EventListenerBreakpointsSidebarPane.js
diff --git a/third_party/WebKit/Source/devtools/front_end/sources/EventListenerBreakpointsSidebarPane.js b/third_party/WebKit/Source/devtools/front_end/sources/EventListenerBreakpointsSidebarPane.js
index 5589753eaf82b67e1234cafab7b113b4e9904731..92761c6e28f398b04dcd0ecad16cd9081a7ef6f7 100644
--- a/third_party/WebKit/Source/devtools/front_end/sources/EventListenerBreakpointsSidebarPane.js
+++ b/third_party/WebKit/Source/devtools/front_end/sources/EventListenerBreakpointsSidebarPane.js
@@ -23,9 +23,10 @@ Sources.EventListenerBreakpointsSidebarPane = class extends UI.VBox {
// Otherwise, inspector page reacts on drop event and tries to load the event data.
// this._createCategory(Common.UIString("Drag"), ["drag", "drop", "dragstart", "dragend", "dragenter", "dragleave", "dragover"]);
this._createCategory(
- Common.UIString('Animation'), ['requestAnimationFrame', 'cancelAnimationFrame', 'animationFrameFired'], true);
- this._createCategory(Common.UIString('Canvas'), ['canvasContextCreated', 'webglErrorFired', 'webglWarningFired'],
- true);
+ Common.UIString('Animation'),
+ ['DOMWindow.requestAnimationFrame', 'DOMWindow.cancelAnimationFrame', 'animationFrameFired'], true);
+ this._createCategory(
+ Common.UIString('Canvas'), ['canvasContextCreated', 'webglErrorFired', 'webglWarningFired'], true);
this._createCategory(
Common.UIString('Clipboard'), ['copy', 'cut', 'paste', 'beforecopy', 'beforecut', 'beforepaste']);
this._createCategory(
@@ -37,7 +38,8 @@ Sources.EventListenerBreakpointsSidebarPane = class extends UI.VBox {
'DOMNodeInsertedIntoDocument', 'DOMNodeRemoved', 'DOMNodeRemovedFromDocument', 'DOMSubtreeModified',
'DOMContentLoaded'
]);
- this._createCategory(Common.UIString('Geolocation'), ['navigator.geolocation.getCurrentPosition', 'navigator.geolocation.watchPosition'], true);
+ this._createCategory(
+ Common.UIString('Geolocation'), ['Geolocation.getCurrentPosition', 'Geolocation.watchPosition'], true);
this._createCategory(Common.UIString('Drag / drop'), ['dragenter', 'dragover', 'dragleave', 'drop']);
this._createCategory(Common.UIString('Keyboard'), ['keydown', 'keyup', 'keypress', 'input']);
this._createCategory(
@@ -56,7 +58,7 @@ Sources.EventListenerBreakpointsSidebarPane = class extends UI.VBox {
'mouseleave', 'mousewheel', 'wheel', 'contextmenu'
]);
this._createCategory(Common.UIString('Notification'), ['Notification.requestPermission'], true);
- this._createCategory(Common.UIString('Parse'), ['setInnerHTML', 'document.write'], true);
+ this._createCategory(Common.UIString('Parse'), ['setInnerHTML', 'Document.write'], true);
this._createCategory(Common.UIString('Pointer'), [
'pointerover', 'pointerout', 'pointerenter', 'pointerleave', 'pointerdown', 'pointerup', 'pointermove',
'pointercancel', 'gotpointercapture', 'lostpointercapture'
@@ -64,7 +66,7 @@ Sources.EventListenerBreakpointsSidebarPane = class extends UI.VBox {
this._createCategory(Common.UIString('Script'), ['scriptFirstStatement', 'scriptBlockedByCSP'], true);
this._createCategory(Common.UIString('Timer'), ['setTimer', 'clearTimer', 'timerFired'], true);
this._createCategory(Common.UIString('Touch'), ['touchstart', 'touchmove', 'touchend', 'touchcancel']);
- this._createCategory(Common.UIString('Window'), ['close'], true);
+ this._createCategory(Common.UIString('Window'), ['DOMWindow.close'], true);
this._createCategory(
Common.UIString('XHR'),
['readystatechange', 'load', 'loadstart', 'loadend', 'abort', 'error', 'progress', 'timeout'], false,
@@ -89,16 +91,18 @@ Sources.EventListenerBreakpointsSidebarPane = class extends UI.VBox {
'instrumentation:timerFired': Common.UIString('Timer Fired'),
'instrumentation:scriptFirstStatement': Common.UIString('Script First Statement'),
'instrumentation:scriptBlockedByCSP': Common.UIString('Script Blocked by Content Security Policy'),
- 'instrumentation:requestAnimationFrame': Common.UIString('Request Animation Frame'),
- 'instrumentation:cancelAnimationFrame': Common.UIString('Cancel Animation Frame'),
- 'instrumentation:animationFrameFired': Common.UIString('Animation Frame Fired'),
+ 'instrumentation:DOMWindow.requestAnimationFrame': Common.UIString('Request Animation Frame'),
+ 'instrumentation:DOMWindow.cancelAnimationFrame': Common.UIString('Cancel Animation Frame'),
+ 'instrumentation:DOMWindow.requestAnimationFrame.callback': Common.UIString('Animation Frame Fired'),
'instrumentation:webglErrorFired': Common.UIString('WebGL Error Fired'),
'instrumentation:webglWarningFired': Common.UIString('WebGL Warning Fired'),
- 'instrumentation:setInnerHTML': Common.UIString('Set innerHTML'),
+ 'instrumentation:Element.setInnerHTML': Common.UIString('Set innerHTML'),
'instrumentation:canvasContextCreated': Common.UIString('Create canvas context'),
- 'instrumentation:navigator.geolocation.getCurrentPosition': 'getCurrentPosition',
- 'instrumentation:navigator.geolocation.watchPosition': 'watchPosition',
+ 'instrumentation:Geolocation.getCurrentPosition': 'getCurrentPosition',
+ 'instrumentation:Geolocation.watchPosition': 'watchPosition',
'instrumentation:Notification.requestPermission': 'requestPermission',
+ 'instrumentation:DOMWindow.close': 'window.close',
+ 'instrumentation:Document.write': 'document.write',
};
}
if (auxData) {
« no previous file with comments | « third_party/WebKit/Source/core/frame/DOMWindow.cpp ('k') | third_party/WebKit/Source/modules/geolocation/Geolocation.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698