Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(177)

Unified Diff: third_party/WebKit/Source/core/dom/FrameRequestCallbackCollection.cpp

Issue 2700263003: DevTools: normalize native breakpoint names. (Closed)
Patch Set: fixed the test Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/core/dom/Element.cpp ('k') | third_party/WebKit/Source/core/frame/DOMWindow.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/dom/FrameRequestCallbackCollection.cpp
diff --git a/third_party/WebKit/Source/core/dom/FrameRequestCallbackCollection.cpp b/third_party/WebKit/Source/core/dom/FrameRequestCallbackCollection.cpp
index 3fef3b49d5976f4435afecde81887de5d5d664da..167ddabab2933155039ddfd1914ec85c9a0a2386 100644
--- a/third_party/WebKit/Source/core/dom/FrameRequestCallbackCollection.cpp
+++ b/third_party/WebKit/Source/core/dom/FrameRequestCallbackCollection.cpp
@@ -29,7 +29,7 @@ FrameRequestCallbackCollection::registerCallback(
InspectorInstrumentation::asyncTaskScheduled(
m_context, "requestAnimationFrame", callback);
InspectorInstrumentation::NativeBreakpoint nativeBreakpoint(
- m_context, "requestAnimationFrame", true);
+ m_context, "DOMWindow.requestAnimationFrame", true);
return id;
}
@@ -38,7 +38,7 @@ void FrameRequestCallbackCollection::cancelCallback(CallbackId id) {
if (m_callbacks[i]->m_id == id) {
InspectorInstrumentation::asyncTaskCanceled(m_context, m_callbacks[i]);
InspectorInstrumentation::NativeBreakpoint nativeBreakpoint(
- m_context, "cancelAnimationFrame", true);
+ m_context, "DOMWindow.cancelAnimationFrame", true);
m_callbacks.remove(i);
TRACE_EVENT_INSTANT1("devtools.timeline", "CancelAnimationFrame",
TRACE_EVENT_SCOPE_THREAD, "data",
@@ -50,7 +50,7 @@ void FrameRequestCallbackCollection::cancelCallback(CallbackId id) {
if (callback->m_id == id) {
InspectorInstrumentation::asyncTaskCanceled(m_context, callback);
InspectorInstrumentation::NativeBreakpoint nativeBreakpoint(
- m_context, "cancelAnimationFrame", true);
+ m_context, "DOMWindow.cancelAnimationFrame", true);
TRACE_EVENT_INSTANT1("devtools.timeline", "CancelAnimationFrame",
TRACE_EVENT_SCOPE_THREAD, "data",
InspectorAnimationFrameEvent::data(m_context, id));
@@ -75,7 +75,7 @@ void FrameRequestCallbackCollection::executeCallbacks(
"devtools.timeline", "FireAnimationFrame", "data",
InspectorAnimationFrameEvent::data(m_context, callback->m_id));
InspectorInstrumentation::NativeBreakpoint nativeBreakpoint(
- m_context, "animationFrameFired", false);
+ m_context, "DOMWindow.requestAnimationFrame.callback", false);
InspectorInstrumentation::AsyncTask asyncTask(m_context, callback);
PerformanceMonitor::HandlerCall handlerCall(
m_context, "requestAnimationFrame", true);
« no previous file with comments | « third_party/WebKit/Source/core/dom/Element.cpp ('k') | third_party/WebKit/Source/core/frame/DOMWindow.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698