Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(101)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 27002004: CSSPropertyTextIndent should be a member of css3TextProperties. (Closed)

Created:
7 years, 2 months ago by dw.im
Modified:
7 years, 2 months ago
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

CSSPropertyTextIndent should be a member of css3TextProperties. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=159668

Patch Set 1 #

Total comments: 2

Patch Set 2 : Add test at the nonstable-css-properties.html #

Patch Set 3 : Add the expected result of virtual/stable directory #

Patch Set 4 : Patch for landing #

Patch Set 5 : Patch for landing 2 #

Patch Set 6 : Patch for landing 3 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -1 line) Patch
M LayoutTests/virtual/stable/webexposed/css-properties-as-js-properties-expected.txt View 1 2 3 4 5 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/virtual/stable/webexposed/nonstable-css-properties-expected.txt View 1 2 3 4 5 1 chunk +8 lines, -0 lines 0 comments Download
M LayoutTests/webexposed/nonstable-css-properties.html View 1 1 chunk +3 lines, -0 lines 0 comments Download
M LayoutTests/webexposed/nonstable-css-properties-expected.txt View 1 1 chunk +8 lines, -0 lines 0 comments Download
M Source/core/page/RuntimeCSSEnabled.cpp View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 18 (0 generated)
dw.im
7 years, 2 months ago (2013-10-14 09:18:13 UTC) #1
Julien - ping for review
https://codereview.chromium.org/27002004/diff/1/Source/core/page/RuntimeCSSEnabled.cpp File Source/core/page/RuntimeCSSEnabled.cpp (right): https://codereview.chromium.org/27002004/diff/1/Source/core/page/RuntimeCSSEnabled.cpp#newcode77 Source/core/page/RuntimeCSSEnabled.cpp:77: CSSPropertyTextIndent, This should be tested by a webexposed/ LayoutTests ...
7 years, 2 months ago (2013-10-14 12:04:09 UTC) #2
dw.im
https://codereview.chromium.org/27002004/diff/1/Source/core/page/RuntimeCSSEnabled.cpp File Source/core/page/RuntimeCSSEnabled.cpp (right): https://codereview.chromium.org/27002004/diff/1/Source/core/page/RuntimeCSSEnabled.cpp#newcode77 Source/core/page/RuntimeCSSEnabled.cpp:77: CSSPropertyTextIndent, On 2013/10/14 12:04:10, Julien Chaffraix wrote: > This ...
7 years, 2 months ago (2013-10-14 12:47:47 UTC) #3
Julien - ping for review
lgtm
7 years, 2 months ago (2013-10-14 13:06:19 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dw.im@samsung.com/27002004/5001
7 years, 2 months ago (2013-10-14 13:06:25 UTC) #5
commit-bot: I haz the power
Retried try job too often on linux_blink_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_blink_rel&number=8058
7 years, 2 months ago (2013-10-14 14:06:04 UTC) #6
Julien - ping for review
Missed that, we remove the empty BUG= line from the description in Blink (the only ...
7 years, 2 months ago (2013-10-14 14:08:14 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dw.im@samsung.com/27002004/5001
7 years, 2 months ago (2013-10-14 15:33:25 UTC) #8
commit-bot: I haz the power
Retried try job too often on linux_blink_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_blink_rel&number=8079
7 years, 2 months ago (2013-10-14 16:28:08 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dw.im@samsung.com/27002004/5001
7 years, 2 months ago (2013-10-14 23:56:32 UTC) #10
commit-bot: I haz the power
Retried try job too often on linux_blink_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_blink_rel&number=8199
7 years, 2 months ago (2013-10-15 00:56:22 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dw.im@samsung.com/27002004/40001
7 years, 2 months ago (2013-10-15 02:00:22 UTC) #12
commit-bot: I haz the power
Retried try job too often on linux_blink_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_blink_rel&number=8220
7 years, 2 months ago (2013-10-15 03:10:48 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dw.im@samsung.com/27002004/54001
7 years, 2 months ago (2013-10-15 04:38:47 UTC) #14
commit-bot: I haz the power
Retried try job too often on linux_blink_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_blink_rel&number=8238
7 years, 2 months ago (2013-10-15 05:39:38 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dw.im@samsung.com/27002004/67001
7 years, 2 months ago (2013-10-15 07:08:57 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dw.im@samsung.com/27002004/77001
7 years, 2 months ago (2013-10-15 10:56:41 UTC) #17
commit-bot: I haz the power
7 years, 2 months ago (2013-10-15 13:00:08 UTC) #18
Message was sent while issue was closed. 
Change committed as 159668

Powered by Google App Engine
This is Rietveld 408576698