Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(147)

Issue 2700153002: Skip running reify testscases on test bots (Closed)

Created:
3 years, 10 months ago by Dmitry Stefantsov
Modified:
3 years, 10 months ago
Reviewers:
karlklose
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Skip running reify testscases on test bots These tests aren't meant to be run. Instead, they should be transformed by the reify transformation and compared against the expected outcomes. TBR=karlklose@google.com Committed: https://github.com/dart-lang/sdk/commit/5068fde200cb61904e3d5e74ec9ba39a58168615

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M pkg/pkg.status View 1 chunk +5 lines, -0 lines 1 comment Download

Messages

Total messages: 3 (1 generated)
Dmitry Stefantsov
Committed patchset #1 (id:1) manually as 5068fde200cb61904e3d5e74ec9ba39a58168615 (presubmit successful).
3 years, 10 months ago (2017-02-17 14:13:36 UTC) #2
karlklose
3 years, 10 months ago (2017-02-17 14:32:41 UTC) #3
Message was sent while issue was closed.
LGTM

https://codereview.chromium.org/2700153002/diff/1/pkg/pkg.status
File pkg/pkg.status (right):

https://codereview.chromium.org/2700153002/diff/1/pkg/pkg.status#newcode34
pkg/pkg.status:34: # routines and compared atainst the expected outcomes.
'atainst' -> 'against'

Powered by Google App Engine
This is Rietveld 408576698