Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(245)

Issue 27001002: Add the ability to generate a depfile when running grit build. (Closed)

Created:
7 years, 2 months ago by Jói
Modified:
7 years, 2 months ago
CC:
grit-developer_googlegroups.com
Visibility:
Public.

Description

Add the ability to generate a depfile when running grit build. This is analogous to the ability of some compilers to generate depfiles that contain the .h files a .cc file depends on when it compiles it. This is useful for speeding up build systems because the input dependencies don't need to be determined before compilation. As there are no pre-determined outputs from a .grd file (all the outputs are determined by the file contents) the depfile refers to itself and acts as a stamp for the generated outputs. BUG=297672 Original author koz@chromium.org. Original patch is issue 25683011. Committed: https://code.google.com/p/grit-i18n/source/detail?r=137

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+78 lines, -4 lines) Patch
M grit/tool/build.py View 5 chunks +55 lines, -4 lines 0 comments Download
M grit/tool/build_unittest.py View 1 chunk +23 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Jói
Will TBR. Cheers, Jói
7 years, 2 months ago (2013-10-11 09:53:15 UTC) #1
Jói
7 years, 2 months ago (2013-10-11 09:53:33 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r137 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698