pkg/compiler/lib/src/js_emitter/runtime_type_generator.dart - Issue 2700053003: Don't use magic strings/properties to communicate between compiler and runtime.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/compiler/lib/src/js_emitter/runtime_type_generator.dart

Issue 2700053003: Don't use magic strings/properties to communicate between compiler and runtime. (Closed)

Patch Set: Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: pkg/compiler/lib/src/js_emitter/runtime_type_generator.dart

diff --git a/pkg/compiler/lib/src/js_emitter/runtime_type_generator.dart b/pkg/compiler/lib/src/js_emitter/runtime_type_generator.dart

index 6d4066e14875fd93b59a43ebffeee3d8902f3340..a80b3a42340d1cffadc03c505abb0c4161f4005d 100644

--- a/pkg/compiler/lib/src/js_emitter/runtime_type_generator.dart

+++ b/pkg/compiler/lib/src/js_emitter/runtime_type_generator.dart

@@ -354,7 +354,7 @@ class RuntimeTypeGenerator {

Substitution substitution =

backend.rti.getSubstitution(cls, element.typeDeclaration);

- jsAst.Name rtiFieldName = backend.namer.rtiFieldName;

+ jsAst.Name rtiFieldName = backend.namer.rtiFieldJsName;

if (substitution != null) {

computeTypeVariable = js(r'#.apply(null, this.#)', [

backend.rtiEncoder.getSubstitutionCodeForVariable(substitution, index),