Issue 270003002: [Password Generation] Update suggested text.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 270003002: [Password Generation] Update suggested text. (Closed)

Created:
6 years, 7 months ago by Garrett Casto

Modified:
6 years, 7 months ago

Reviewers:
Ilya Sherman

CC:
chromium-reviews, rolfe

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

[Password Generation] Update suggested text. Explicitly mentiont that this password is coming from Chrome. BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=268411

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -3 lines)			Patch
M	chrome/app/chromium_strings.grd	View	1	1 chunk	+3 lines, -0 lines	0 comments	Download
M	chrome/app/generated_resources.grd	View		1 chunk	+0 lines, -3 lines	0 comments	Download
M	chrome/app/google_chrome_strings.grd	View	1	1 chunk	+3 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/autofill/password_generation_popup_controller_impl.cc	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download

Total messages: 7 (0 generated)

Garrett Casto

Hi Ilya, This is a tiny change that I would just send to Rebecca but ...

6 years, 7 months ago (2014-05-05 20:13:04 UTC) #1

Ilya Sherman

Since the string now mentions "Chrome" specifically, can you move it into google_chrome_strings.grd and chromium_strings.grd?

6 years, 7 months ago (2014-05-05 21:46:58 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gcasto@chromium.org/270003002/20001

6 years, 7 months ago (2014-05-05 23:29:16 UTC) #6

Message was sent while issue was closed.

Change committed as 268411