Handlify GetNormalizedProperty.

src/property.h

 // Copyright 2012 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 445 matching lines @@
 
   Object* GetCallbackObject() {
     ASSERT(type() == CALLBACKS && !IsTransition());
     return GetValue();
   }
 
 #ifdef OBJECT_PRINT
   void Print(FILE* out);
 #endif
 
   Object* GetValue() {

[Michael Starzinger, 2013/10/23 11:01:53]

This method has several call-sites in unhandlified code (e.g. look for callers
of GetCallbackObject). This unfortunately means that this handlification is
currently invalid as it potentially leaves stale pointers.

     if (lookup_type_ == DESCRIPTOR_TYPE) {
       return GetValueFromMap(holder()->map());
     }
     // In the dictionary case, the data is held in the value field.
     ASSERT(lookup_type_ == DICTIONARY_TYPE);
-    return holder()->GetNormalizedProperty(this);
+    HandleScope scope(holder()->GetIsolate());
+    return *JSObject::GetNormalizedProperty(handle(holder()), this);
   }
 
   Object* GetValueFromMap(Map* map) const {
     ASSERT(lookup_type_ == DESCRIPTOR_TYPE);
     ASSERT(number_ < map->NumberOfOwnDescriptors());
     return map->instance_descriptors()->GetValue(number_);
   }
 
   int GetFieldIndexFromMap(Map* map) const {
     ASSERT(lookup_type_ == DESCRIPTOR_TYPE);
@@ skipping 20 matching lines @@
   JSReceiver* holder_;
   int number_;
   bool cacheable_;
   PropertyDetails details_;
 };
 
 
 } }  // namespace v8::internal
 
 #endif  // V8_PROPERTY_H_