Issue 27000006: Handlify GetNormalizedProperty.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 27000006: Handlify GetNormalizedProperty. (Closed)

Created:
7 years, 2 months ago by Yang

Modified:
6 years, 9 months ago

Reviewers:
Michael Starzinger

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Handlify GetNormalizedProperty. R=mstarzinger@chromium.org BUG=

Patch Set 1 #

Total comments: 1

Created: 7 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+42 lines, -37 lines)			Patch
M	src/objects.h	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	src/objects.cc	View	2 chunks	+15 lines, -8 lines	0 comments	Download
M	src/property.h	View	1 chunk	+2 lines, -1 line	1 comment	Download
M	src/runtime.cc	View	9 chunks	+19 lines, -20 lines	0 comments	Download
A +	test/mjsunit/regress/regress-getdataproperty-const.js	View	1 chunk	+4 lines, -7 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Michael Starzinger

7 years, 2 months ago (2013-10-23 11:01:52 UTC) #3

Unfortunately not LGTM.

https://codereview.chromium.org/27000006/diff/1/src/property.h
File src/property.h (right):

https://codereview.chromium.org/27000006/diff/1/src/property.h#newcode466
src/property.h:466: Object* GetValue() {
This method has several call-sites in unhandlified code (e.g. look for callers
of GetCallbackObject). This unfortunately means that this handlification is
currently invalid as it potentially leaves stale pointers.

Expand Messages | Collapse Messages