Cleanup proxy/defer code

Cleanup proxy/defer code

This cleans up some issues I found when merging this internally.

R=jacobr@google.com

Committed: https://github.com/dart-lang/sdk/commit/5601a604f055b81ff00cc7cd70a9058a8e477086

[vsm, 2017-02-17 15:09:05]

Description was changed from

==========
Cleanup proxy/defer code
==========

to

==========
Cleanup proxy/defer code

This cleans up some issues I found when merging this internally.
==========

[vsm, 2017-02-17 15:16:17]

https://codereview.chromium.org/2699943003/diff/20001/pkg/dev_compiler/lib/js...
File pkg/dev_compiler/lib/js/legacy/dart_library.js (right):

https://codereview.chromium.org/2699943003/diff/20001/pkg/dev_compiler/lib/js...
pkg/dev_compiler/lib/js/legacy/dart_library.js:44: // Class) or set (to write a
top-level variable).
A couple notes:
(1) I'm no longer revoking the proxy - dev tools isn't fond of that.

(2) The lack of 'set' caused some tests to break - e.g., if a library sets a
top-level variable in another library and that's the first access to that other
library, this wasn't handling that.

https://codereview.chromium.org/2699943003/diff/20001/pkg/dev_compiler/lib/js...
pkg/dev_compiler/lib/js/legacy/dart_library.js:99: library[libraryImports] =
this._imports;
Note: these were getting set on the proxy instead of the library object.

https://codereview.chromium.org/2699943003/diff/20001/pkg/dev_compiler/lib/js...
pkg/dev_compiler/lib/js/legacy/dart_library.js:110: this._library = new
Proxy(library, {
Note, this is the module object, not the library object.

I'll make a separate pass to cleanup the nomenclature.

[vsm, 2017-02-17 15:16:36]

vsm@google.com changed reviewers:
+ jacobr@google.com, jmesserly@google.com

[Jacob, 2017-02-17 16:05:51]

lgtm

[vsm, 2017-02-17 16:12:13]

Description was changed from

==========
Cleanup proxy/defer code

This cleans up some issues I found when merging this internally.
==========

to

==========
Cleanup proxy/defer code

This cleans up some issues I found when merging this internally.

R=jacobr@google.com

Committed:
https://github.com/dart-lang/sdk/commit/5601a604f055b81ff00cc7cd70a9058a8e477086
==========

[vsm, 2017-02-17 16:12:15]

Committed patchset #2 (id:20001) manually as
5601a604f055b81ff00cc7cd70a9058a8e477086 (presubmit successful).