chrome/browser/page_load_metrics/observers/aborts_page_load_metrics_observer.h - Issue 2699933003: Generalize abort tracking to page end state tracking

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/page_load_metrics/observers/aborts_page_load_metrics_observer.h

Issue 2699933003: Generalize abort tracking to page end state tracking (Closed)

Patch Set: add additional histogram Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/page_load_metrics/metrics_web_contents_observer.cc ('K') | « chrome/browser/page_load_metrics/metrics_web_contents_observer.cc ('k') | chrome/browser/page_load_metrics/observers/aborts_page_load_metrics_observer.cc » ('j') | chrome/browser/page_load_metrics/page_load_tracker.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/page_load_metrics/observers/aborts_page_load_metrics_observer.h

diff --git a/chrome/browser/page_load_metrics/observers/aborts_page_load_metrics_observer.h b/chrome/browser/page_load_metrics/observers/aborts_page_load_metrics_observer.h

index 56b11fdf21901ce22220c0b43abe2a5a23136dc3..f261dc6c865473e283ec79b08f1fcf40991b89c9 100644

--- a/chrome/browser/page_load_metrics/observers/aborts_page_load_metrics_observer.h

+++ b/chrome/browser/page_load_metrics/observers/aborts_page_load_metrics_observer.h

@@ -13,7 +13,6 @@ namespace internal {

extern const char kHistogramAbortForwardBackBeforeCommit[];

extern const char kHistogramAbortReloadBeforeCommit[];

extern const char kHistogramAbortNewNavigationBeforeCommit[];

-extern const char kHistogramAbortClientRedirectBeforeCommit[];

extern const char kHistogramAbortStopBeforeCommit[];

extern const char kHistogramAbortCloseBeforeCommit[];

extern const char kHistogramAbortBackgroundBeforeCommit[];