Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6575)

Unified Diff: chrome/browser/page_load_metrics/page_load_metrics_browsertest.cc

Issue 2699933003: Generalize abort tracking to page end state tracking (Closed)
Patch Set: fix histogram typo Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/page_load_metrics/page_load_metrics_browsertest.cc
diff --git a/chrome/browser/page_load_metrics/page_load_metrics_browsertest.cc b/chrome/browser/page_load_metrics/page_load_metrics_browsertest.cc
index a9c4f95aaefd8c1a784d23fd795b897011129fcb..763e0547f55b1e5bede7cb4e923f3419e5e4b0d6 100644
--- a/chrome/browser/page_load_metrics/page_load_metrics_browsertest.cc
+++ b/chrome/browser/page_load_metrics/page_load_metrics_browsertest.cc
@@ -439,34 +439,6 @@ IN_PROC_BROWSER_TEST_F(PageLoadMetricsBrowserTest, AbortMultiple) {
internal::kHistogramAbortNewNavigationBeforeCommit, 2);
}
-IN_PROC_BROWSER_TEST_F(PageLoadMetricsBrowserTest, AbortClientRedirect) {
Charlie Harrison 2017/02/17 22:36:49 Please keep this test ans just assert we don't log
Bryan McQuade 2017/02/18 00:30:15 Done
- ASSERT_TRUE(embedded_test_server()->Start());
-
- GURL first_url(embedded_test_server()->GetURL("/title1.html"));
- ui_test_utils::NavigateToURL(browser(), first_url);
-
- GURL second_url(embedded_test_server()->GetURL("/title2.html"));
- chrome::NavigateParams params(browser(), second_url,
- ui::PAGE_TRANSITION_LINK);
- content::TestNavigationManager manager(
- browser()->tab_strip_model()->GetActiveWebContents(), second_url);
- chrome::Navigate(&params);
- EXPECT_TRUE(manager.WaitForRequestStart());
-
- {
- content::TestNavigationManager reload_manager(
- browser()->tab_strip_model()->GetActiveWebContents(), first_url);
- EXPECT_TRUE(content::ExecuteScript(
- browser()->tab_strip_model()->GetActiveWebContents(),
- "window.location.reload();"));
- }
-
- manager.WaitForNavigationFinished();
-
- histogram_tester_.ExpectTotalCount(
- internal::kHistogramAbortClientRedirectBeforeCommit, 1);
-}
-
IN_PROC_BROWSER_TEST_F(PageLoadMetricsBrowserTest,
FirstMeaningfulPaintRecorded) {
ASSERT_TRUE(embedded_test_server()->Start());

Powered by Google App Engine
This is Rietveld 408576698