Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(587)

Unified Diff: runtime/include/dart_api.h

Issue 2699853002: Sort class IDs before training AppJIT snapshots (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/include/dart_api.h
diff --git a/runtime/include/dart_api.h b/runtime/include/dart_api.h
index 9aff87019e0f837eb99222f2ec70e7c76f2a1bfd..424776001ae5a2896d9d3f5d86399bb14cb69796 100644
--- a/runtime/include/dart_api.h
+++ b/runtime/include/dart_api.h
@@ -3279,6 +3279,15 @@ Dart_CreateAppAOTSnapshotAsBlobs(uint8_t** vm_snapshot_data_buffer,
/**
+ * Sorts the class-ids in depth first traversal order of the inheritance
+ * tree. This is a costly operation, but it can make method dispatch
+ * more efficient and is done before writing snapshots.
+ */
+DART_EXPORT void
Florian Schneider 2017/02/16 10:05:06 Formatting: One line?
erikcorry 2017/02/20 12:35:19 Done.
+Dart_SortClasses();
+
+
+/**
* Creates a snapshot that caches compiled code and type feedback for faster
* startup and quicker warmup in a subsequent process.
*
« no previous file with comments | « runtime/bin/main.cc ('k') | runtime/vm/class_finalizer.h » ('j') | runtime/vm/dart_api_impl.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698