Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(604)

Unified Diff: net/http/http_stream_factory_impl_job_controller.cc

Issue 2699833007: Add net-log entries when HttpStream jobs are forced to wait, and when they're delayed and resumed. (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/http/http_stream_factory_impl_job_controller.h ('k') | net/log/net_log_event_type_list.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/http/http_stream_factory_impl_job_controller.cc
diff --git a/net/http/http_stream_factory_impl_job_controller.cc b/net/http/http_stream_factory_impl_job_controller.cc
index 052a17e3da2ab5a6d5a396109eb900c3d88ba903..2bcf4f00562b6064b21e7945be730d3b882bc641 100644
--- a/net/http/http_stream_factory_impl_job_controller.cc
+++ b/net/http/http_stream_factory_impl_job_controller.cc
@@ -27,15 +27,6 @@
namespace net {
-// Returns parameters associated with the delay of the HTTP stream job.
-std::unique_ptr<base::Value> NetLogHttpStreamJobDelayCallback(
- base::TimeDelta delay,
- NetLogCaptureMode /* capture_mode */) {
- std::unique_ptr<base::DictionaryValue> dict(new base::DictionaryValue());
- dict->SetInteger("resume_after_ms", static_cast<int>(delay.InMilliseconds()));
- return std::move(dict);
-}
-
HttpStreamFactoryImpl::JobController::JobController(
HttpStreamFactoryImpl* factory,
HttpStreamRequest::Delegate* delegate,
@@ -515,10 +506,21 @@ void HttpStreamFactoryImpl::JobController::AddConnectionAttemptsToRequest(
request_->AddConnectionAttempts(attempts);
}
+void HttpStreamFactoryImpl::JobController::ResumeMainJobLater(
+ const base::TimeDelta& delay) {
+ net_log_.AddEvent(NetLogEventType::HTTP_STREAM_JOB_DELAYED,
+ NetLog::Int64Callback("delay", delay.InMilliseconds()));
+ base::ThreadTaskRunnerHandle::Get()->PostDelayedTask(
+ FROM_HERE,
+ base::Bind(&HttpStreamFactoryImpl::JobController::ResumeMainJob,
+ ptr_factory_.GetWeakPtr()),
+ delay);
+}
+
void HttpStreamFactoryImpl::JobController::ResumeMainJob() {
main_job_->net_log().AddEvent(
- NetLogEventType::HTTP_STREAM_JOB_DELAYED,
- base::Bind(&NetLogHttpStreamJobDelayCallback, main_job_wait_time_));
+ NetLogEventType::HTTP_STREAM_JOB_RESUMED,
+ NetLog::Int64Callback("delay", main_job_wait_time_.InMilliseconds()));
main_job_->Resume();
main_job_wait_time_ = base::TimeDelta();
@@ -537,11 +539,7 @@ void HttpStreamFactoryImpl::JobController::MaybeResumeMainJob(
if (!main_job_->is_waiting())
return;
- base::ThreadTaskRunnerHandle::Get()->PostDelayedTask(
- FROM_HERE,
- base::Bind(&HttpStreamFactoryImpl::JobController::ResumeMainJob,
- ptr_factory_.GetWeakPtr()),
- main_job_wait_time_);
+ ResumeMainJobLater(main_job_wait_time_);
}
void HttpStreamFactoryImpl::JobController::OnConnectionInitialized(Job* job,
@@ -564,12 +562,7 @@ bool HttpStreamFactoryImpl::JobController::ShouldWait(Job* job) {
if (main_job_wait_time_.is_zero())
return false;
- base::ThreadTaskRunnerHandle::Get()->PostDelayedTask(
- FROM_HERE,
- base::Bind(&HttpStreamFactoryImpl::JobController::ResumeMainJob,
- ptr_factory_.GetWeakPtr()),
- main_job_wait_time_);
-
+ ResumeMainJobLater(main_job_wait_time_);
return true;
}
« no previous file with comments | « net/http/http_stream_factory_impl_job_controller.h ('k') | net/log/net_log_event_type_list.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698