|
|
Created:
3 years, 10 months ago by Sigurður Ásgeirsson Modified:
3 years, 10 months ago CC:
chromium-reviews, vmpstr+watch_chromium.org Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionEnable the memory task profiler in all builds where the heap shim is available.
BUG=644385
Review-Url: https://codereview.chromium.org/2699833006
Cr-Commit-Position: refs/heads/master@{#451527}
Committed: https://chromium.googlesource.com/chromium/src/+/97c2faae478f944add1951dc0cdcb5556e1d60b4
Patch Set 1 #
Total comments: 2
Patch Set 2 : Address Gab's nit. #Messages
Total messages: 19 (13 generated)
The CQ bit was checked by siggi@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
siggi@chromium.org changed reviewers: + gab@chromium.org, primiano@chromium.org
Hey guys, I'd like to enable the memory task profiler now that most all the overhead is under a command line flag. This should only add a pair of conditional tests to each task run. Primiano for functionality, Gab for OWNERS please. I don't think I'll land this today, as Friday, but would be nice to sneak it in Sunday for Monday's canary. Siggi
non-owner LGTM since this is now behind a flag. P.S. would be nice at some point in the future to cleanup the ifdef, since at this point ENABLE_MEMORY_TASK_PROFILER is == USE_EXPERIMENTAL_ALLOCATOR_SHIM, but not a urgent matter
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
On 2017/02/17 16:38:18, Primiano Tucci wrote: > non-owner LGTM since this is now behind a flag. r-s lgtm w/ comment nit > > P.S. would be nice at some point in the future to cleanup the ifdef, since at > this point ENABLE_MEMORY_TASK_PROFILER is == USE_EXPERIMENTAL_ALLOCATOR_SHIM, > but not a urgent matter https://codereview.chromium.org/2699833006/diff/1/base/BUILD.gn File base/BUILD.gn (right): https://codereview.chromium.org/2699833006/diff/1/base/BUILD.gn#newcode41 base/BUILD.gn:41: # available. The can then be enabled at runtime by passing the command line "The can then" ? :)
The CQ bit was checked by siggi@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Thanks! https://codereview.chromium.org/2699833006/diff/1/base/BUILD.gn File base/BUILD.gn (right): https://codereview.chromium.org/2699833006/diff/1/base/BUILD.gn#newcode41 base/BUILD.gn:41: # available. The can then be enabled at runtime by passing the command line On 2017/02/17 21:13:27, gab wrote: > "The can then" ? :) Ugh - I have the best words, don't I :) English is hard, especially writing it or reading it. So are most other languages, I think it's in the words and how they are supposed to go together and make "sense". I don't get it. Sad.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)
The CQ bit was checked by siggi@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from primiano@chromium.org, gab@chromium.org Link to the patchset: https://codereview.chromium.org/2699833006/#ps20001 (title: "Address Gab's nit.")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch. Bot data: {"patchset_id": 20001, "attempt_start_ts": 1487535429286830, "parent_rev": "009add4a66928d0b628d9fb9456710a86ca5cb93", "commit_rev": "97c2faae478f944add1951dc0cdcb5556e1d60b4"}
Message was sent while issue was closed.
Description was changed from ========== Enable the memory task profiler in all builds where the heap shim is available. BUG=644385 ========== to ========== Enable the memory task profiler in all builds where the heap shim is available. BUG=644385 Review-Url: https://codereview.chromium.org/2699833006 Cr-Commit-Position: refs/heads/master@{#451527} Committed: https://chromium.googlesource.com/chromium/src/+/97c2faae478f944add1951dc0cdc... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/97c2faae478f944add1951dc0cdc... |