Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(203)

Issue 2699833006: Enable the memory task profiler in all builds where the heap shim is available. (Closed)

Created:
3 years, 10 months ago by Sigurður Ásgeirsson
Modified:
3 years, 10 months ago
CC:
chromium-reviews, vmpstr+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Enable the memory task profiler in all builds where the heap shim is available. BUG=644385 Review-Url: https://codereview.chromium.org/2699833006 Cr-Commit-Position: refs/heads/master@{#451527} Committed: https://chromium.googlesource.com/chromium/src/+/97c2faae478f944add1951dc0cdcb5556e1d60b4

Patch Set 1 #

Total comments: 2

Patch Set 2 : Address Gab's nit. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M base/BUILD.gn View 1 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 19 (13 generated)
Sigurður Ásgeirsson
Hey guys, I'd like to enable the memory task profiler now that most all the ...
3 years, 10 months ago (2017-02-17 16:34:47 UTC) #4
Primiano Tucci (use gerrit)
non-owner LGTM since this is now behind a flag. P.S. would be nice at some ...
3 years, 10 months ago (2017-02-17 16:38:18 UTC) #5
gab
On 2017/02/17 16:38:18, Primiano Tucci wrote: > non-owner LGTM since this is now behind a ...
3 years, 10 months ago (2017-02-17 21:13:28 UTC) #8
Sigurður Ásgeirsson
Thanks! https://codereview.chromium.org/2699833006/diff/1/base/BUILD.gn File base/BUILD.gn (right): https://codereview.chromium.org/2699833006/diff/1/base/BUILD.gn#newcode41 base/BUILD.gn:41: # available. The can then be enabled at ...
3 years, 10 months ago (2017-02-17 21:49:26 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2699833006/20001
3 years, 10 months ago (2017-02-19 20:17:15 UTC) #16
commit-bot: I haz the power
3 years, 10 months ago (2017-02-19 22:00:50 UTC) #19
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/97c2faae478f944add1951dc0cdc...

Powered by Google App Engine
This is Rietveld 408576698