arc: enable Android tracing from chrome://tracing in dev mode

chromeos/chromeos.gyp

 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 {
   'variables': {
     'chromium_code': 1,
     # These files lists are shared with the GN build.
     'chromeos_sources': [
       'accelerometer/accelerometer_reader.cc',
@@ skipping 390 matching lines @@
       'system/statistics_provider.cc',
       'system/statistics_provider.h',
       'system/version_loader.cc',
       'system/version_loader.h',
       'timezone/timezone_provider.cc',
       'timezone/timezone_provider.h',
       'timezone/timezone_request.cc',
       'timezone/timezone_request.h',
       'timezone/timezone_resolver.cc',
       'timezone/timezone_resolver.h',
+      'trace/arc_trace_agent.cc',

[Daniel Erat, 2017/03/07 15:53:21]

why does this live under //chromeos instead of in //components/arc? creating a
new trace/ subdirectory also seems strange unless you're planning to put more
things here in the future.

[Daniel Erat, 2017/03/08 02:58:40]

unless i'm misreading the code, this new class doesn't have dependencies on
anything besides //base, and it's only used by //content and //chrome (i.e. not
//components/arc). if that's correct, would it be possible to just put it
somewhere within //content? or do you anticipate adding more dependencies later?

yusuke, i think that the location in //chromeos came from your suggestion at
https://codereview.chromium.org/2400163003/ -- can you comment here?

[Earl Ou, 2017/03/08 03:18:08]

Looks OK for me.

1. There is /content/browser/android, and the controller for Chrome tracing on
Android is there. Does it make sense to create /content/browser/arc and put
these two files there?

2. Or maybe we can just put arc_trace_agent.h in /content/browser/tracing,
similar to the other tracing agents, e.g., power_tracing_agent,
etw_tracing_agent.

The solution 2 seems better for me, but would like to hear the comments from
reviewers here.

[Daniel Erat, 2017/03/08 04:58:06]

or maybe /content/browser/chromeos?
yeah, i think that this sounds slightly better to me too if there are already
other agents there.

[Yusuke Sato, 2017/03/08 07:17:44]

I made the suggestion just because I wasn't really sure if content/ OWNERS were
okay with having ARC specific files there (currently there's zero arc_*.{cc,h}
files in content/.) If they're okay, I have no objection to the plan to move the
files to content/.

+      'trace/arc_trace_agent.h',
       'tpm/tpm_password_fetcher.cc',
       'tpm/tpm_password_fetcher.h',
       'tpm/tpm_token_info_getter.cc',
       'tpm/tpm_token_info_getter.h',
       'tpm/tpm_token_loader.cc',
       'tpm/tpm_token_loader.h'
     ],
     'chromeos_binder_test_sources': [
       'binder/buffer_reader_unittest.cc',
       'binder/command_broker_unittest.cc',
@@ skipping 335 matching lines @@
             '../build/isolate.gypi',
           ],
           'sources': [
             'chromeos_unittests.isolate',
           ],
         },
       ],
     }],
   ],
 }