arc: enable Android tracing from chrome://tracing in dev mode

chromeos/trace/arc_trace_agent.h

+// Copyright 2017 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CHROMEOS_TRACE_ARC_TRACE_AGENT_H_
+#define CHROMEOS_TRACE_ARC_TRACE_AGENT_H_
+
+#include <string>

[Luis Héctor Chávez, 2017/02/16 16:45:10]

unused?

[Earl Ou, 2017/02/17 02:12:59]

Removed

+
+#include "base/callback.h"

[Luis Héctor Chávez, 2017/02/16 16:45:11]

Maybe "base/callback_forward.h"?

[Earl Ou, 2017/02/17 02:12:59]

Done.

+#include "base/files/scoped_file.h"

[Luis Héctor Chávez, 2017/02/16 16:45:11]

unused

[Earl Ou, 2017/02/17 02:12:59]

Done.

+#include "base/trace_event/trace_event.h"
+#include "base/trace_event/tracing_agent.h"
+#include "chromeos/chromeos_export.h"
+
+namespace chromeos {
+
+// A wrapper for controlling tracing in ARC container.
+class CHROMEOS_EXPORT ArcTraceAgent : public base::trace_event::TracingAgent {

[Luis Héctor Chávez, 2017/02/16 16:45:11]

Maybe add a comment about how this class should only be interacted with in the
UI thread.

[Earl Ou, 2017/02/17 02:12:59]

Done.

+ public:
+  class Delegate {
+   public:
+    using StartTracingCallback = base::Callback<void(bool)>;
+    using StopTracingCallback = base::Callback<void(bool)>;
+
+    virtual ~Delegate() = default;

[Luis Héctor Chávez, 2017/02/16 16:45:11]

nit: please move the declarations to the .cc file (this and L35).

[Earl Ou, 2017/02/17 02:12:59]

Done.

+
+    virtual void StartTracing(
+        const base::trace_event::TraceConfig& trace_config,
+        const StartTracingCallback& callback) = 0;
+
+    virtual void StopTracing(const StopTracingCallback& callback) = 0;
+  };
+
+  virtual ~ArcTraceAgent() = default;
+
+  static ArcTraceAgent* GetInstance();
+
+  // Sets Delegate instance, which should implement the communication
+  // using ARC bridge. If set to nullptr, calling of Start/StopAgentTracing
+  // does nothing.
+  virtual void SetDelegate(Delegate* delegate) = 0;
+};
+
+}  // namespace chromeos
+
+#endif  // CHROMEOS_TRACE_ARC_TRACE_AGENT_H_