Issue 269983002: CSS tweaks for typography and rendering of code-related text.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 269983002: CSS tweaks for typography and rendering of code-related text. (Closed)

Created:
6 years, 7 months ago by pearlchen

Modified:
6 years, 7 months ago

Reviewers:
mkearney, Renato Mangini (chromium), not at google - send to devlin

CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Highlights of CSS tweaks: (1) The filename of a <pre> block is now hidden until hover. This fixes the data-filename grey box covering code when the first 1-2 lines of code are long. (2) In <pre> blocks, <b> and <strike> are more visible (3) Size of text bumped down slightly to fit more code in but still remain legible. (4) Text in <pre> blocks no longer wrap and horizontal scroll is enabled when a line of code is too long. BUG=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=268307

Patch Set 1 #

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+29 lines, -2 lines)			Patch
M	chrome/common/extensions/docs/static/css/out/site.css	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/common/extensions/docs/static/sass/_html.scss	View	1 chunk	+20 lines, -1 line	0 comments	Download
M	chrome/common/extensions/docs/static/sass/_typography.scss	View	2 chunks	+8 lines, -0 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pearlchen@chromium.org/269983002/1

6 years, 7 months ago (2014-05-05 19:23:22 UTC) #6

Message was sent while issue was closed.

Change committed as 268307

Expand Messages | Collapse Messages