DevTools: add PRESUBMIT hook for browser_protocol.json in Source/core/inspector

third_party/WebKit/Source/devtools/PRESUBMIT.py

 # Copyright (C) 2014 Google Inc. All rights reserved.
 #
 # Redistribution and use in source and binary forms, with or without
 # modification, are permitted provided that the following conditions are
 # met:
 #
 #     * Redistributions of source code must retain the above copyright
 # notice, this list of conditions and the following disclaimer.
 #     * Redistributions in binary form must reproduce the above
 # copyright notice, this list of conditions and the following disclaimer
@@ skipping 16 matching lines @@
 # OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
 """DevTools JSDoc validator presubmit script
 
 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts
 for more details about the presubmit API built into gcl.
 """
 
 from collections import namedtuple
 import sys
 
 compile_note = "Be sure to run your patch by the compile_frontend.py script prior to committing!"

[dgozman, 2017/02/17 01:20:18]

Seems unnecessary now.

[chenwilliam, 2017/02/17 02:17:31]

Done.

 
 CheckOutput = namedtuple('CheckOutput', ['results', 'has_errors'])
 
 
 def _CheckNodeAndNPMModules(input_api, output_api):
     node_script_path = input_api.os_path.join(input_api.PresubmitLocalPath(), "scripts", "install_node_deps.py")
     process = input_api.subprocess.Popen(
         [input_api.python_executable, node_script_path], stdout=input_api.subprocess.PIPE, stderr=input_api.subprocess.STDOUT)
     out, _ = process.communicate()
     if process.returncode != 0:
@@ skipping 57 matching lines @@
             stdout=input_api.subprocess.PIPE,
             stderr=input_api.subprocess.STDOUT)
         out, _ = process.communicate()
         if process.returncode != 0:
             return [output_api.PresubmitError(out)]
         return [output_api.PresubmitNotifyResult(out)]
     return []
 
 
 def _CompileDevtoolsFrontend(input_api, output_api):
-    local_paths = [f.LocalPath() for f in input_api.AffectedFiles()]
-
-    # FIXME: The compilation does not actually run if injected script-related files
-    # have changed, as they reside in core/inspector, which is not affected
-    # by this presubmit.
-    # Once this is fixed, injected_script_externs.js
-    # should be added to the list of triggers.
-    devtools_front_end = input_api.os_path.join("devtools", "front_end")
-    if (any(devtools_front_end in path for path in local_paths) or any("_protocol.json" in path for path in local_paths) or
-            any("compile_frontend.py" in path for path in local_paths) or any("InjectedScriptSource.js" in path
-                                                                              for path in local_paths) or
-            any("DebuggerScript.js" in path for path in local_paths)):
-        lint_path = input_api.os_path.join(input_api.PresubmitLocalPath(), "scripts", "compile_frontend.py")
-        out, _ = input_api.subprocess.Popen(
-            [input_api.python_executable, lint_path], stdout=input_api.subprocess.PIPE,
-            stderr=input_api.subprocess.STDOUT).communicate()
-        if "ERROR" in out or "WARNING" in out:
-            return [output_api.PresubmitError(out)]
-        if "NOTE" in out:
-            return [output_api.PresubmitPromptWarning(out + compile_note)]
+    compile_path = input_api.os_path.join(input_api.PresubmitLocalPath(), "scripts", "compile_frontend.py")
+    out, _ = input_api.subprocess.Popen(
+        [input_api.python_executable, compile_path], stdout=input_api.subprocess.PIPE,
+        stderr=input_api.subprocess.STDOUT).communicate()
+    if "ERROR" in out or "WARNING" in out:
+        return [output_api.PresubmitError(out)]
+    if "NOTE" in out:
+        return [output_api.PresubmitPromptWarning(out + compile_note)]
     return []
 
 
 def _CheckConvertSVGToPNGHashes(input_api, output_api):
     if not input_api.platform.startswith('linux'):
         return []
 
     original_sys_path = sys.path
     try:
         sys.path = sys.path + [input_api.os_path.join(input_api.PresubmitLocalPath(), 'scripts', 'build')]
@@ skipping 99 matching lines @@
     devtools_scripts = input_api.os_path.join(devtools_root, "scripts")
     affected_js_files = [
         file_name for file_name in local_paths
         if (devtools_front_end in file_name or devtools_scripts in file_name) and file_name.endswith(".js")
     ]
     return [input_api.os_path.relpath(file_name, devtools_root) for file_name in affected_js_files]
 
 
 def _inputPopen(input_api, args):
     return input_api.subprocess.Popen(args, stdout=input_api.subprocess.PIPE, stderr=input_api.subprocess.STDOUT)