tools/testing/dart/test_progress.dart - Issue 26998002: Remove pixel/layout tests in tests/utils + special casing in the testing scripts for pixel/layout t…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/testing/dart/test_progress.dart

Issue 26998002: Remove pixel/layout tests in tests/utils + special casing in the testing scripts for pixel/layout t… (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/testing/dart/test_progress.dart

diff --git a/tools/testing/dart/test_progress.dart b/tools/testing/dart/test_progress.dart

index 012a7ec0be73100202743a052506659285e941c9..80b00a0616321a7d777e5a5922655a3d2879d511 100644

--- a/tools/testing/dart/test_progress.dart

+++ b/tools/testing/dart/test_progress.dart

@@ -107,12 +107,7 @@ List<String> _buildFailureOutput(TestCase test,

if (!commandOutput.stdout.isEmpty) {

output.add('');

output.add('stdout:');

- if (command.isPixelTest) {

- output.add('DRT pixel test failed! stdout is not printed because it '

- 'contains binary data!');

- } else {

- output.addAll(getLinesWithoutCarriageReturn(commandOutput.stdout));

- }

+ output.addAll(getLinesWithoutCarriageReturn(commandOutput.stdout));

}

if (!commandOutput.stderr.isEmpty) {

output.add('');

« no previous file with comments | « tools/testing/dart/browser_test.dart ('k') | tools/testing/dart/test_runner.dart » ('j') | no next file with comments »