Remove pixel/layout tests in tests/utils + special casing in the testing scripts for pixel/layout t…

tools/testing/dart/test_suite.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 /**
  * Classes and methods for enumerating and preparing tests.
  *
  * This library includes:
  *
  * - Creating tests by listing all the Dart files in certain directories,
@@ skipping 957 matching lines @@
       String precompiledDartWrapperFilename = '$tempDir/test.precompiled.js';
 
       String content = null;
       Path dir = filePath.directoryPath;
       String nameNoExt = filePath.filenameWithoutExtension;
 
       Path pngPath = dir.append('$nameNoExt.png');
       Path txtPath = dir.append('$nameNoExt.txt');
       String customHtmlPath = dir.append('$nameNoExt.html').toNativePath();
       File customHtml = new File(customHtmlPath);
-      Path expectedOutput = null;
 
       // Construct the command(s) that compile all the inputs needed by the
       // browser test. For running Dart in DRT, this will be noop commands.
       List<Command> commands = [];
 
       // Use existing HTML document if available.
       String htmlPath;
       if (customHtml.existsSync()) {
         // If necessary, run the Polymer deploy steps.
         // TODO(jmesserly): this should be generalized for any tests that
@@ skipping 46 matching lines @@
 
         String scriptPath = dartWrapperFilename;
         if (compiler != 'none') {
           scriptPath = compiledDartWrapperFilename;
           if (configuration['csp']) {
             scriptPath = precompiledDartWrapperFilename;
           }
         }
         scriptPath = _createUrlPathFromFile(new Path(scriptPath));
 
-        if (new File(pngPath.toNativePath()).existsSync()) {
-          expectedOutput = pngPath;
-          content = getHtmlLayoutContents(scriptType, new Path("$scriptPath"));
-        } else if (new File(txtPath.toNativePath()).existsSync()) {
-          expectedOutput = txtPath;
-          content = getHtmlLayoutContents(scriptType, new Path("$scriptPath"));
-        } else {
-          content = getHtmlContents(filename, scriptType,
-              new Path("$scriptPath"));
-        }
+        content =
+            getHtmlContents(filename, scriptType, new Path("$scriptPath"));
         htmlTest.writeStringSync(content);
         htmlTest.closeSync();
       }
 
       if (compiler != 'none') {
         commands.add(_compileCommand(
             dartWrapperFilename, compiledDartWrapperFilename,
             compiler, tempDir, vmOptions, optionsFromFile));
       }
 
@@ skipping 68 matching lines @@
 
           if (compiler == 'none' || compiler == 'dart2dart') {
             dartFlags.add('--ignore-unrecognized-flags');
             if (configuration["checked"]) {
               dartFlags.add('--enable_asserts');
               dartFlags.add("--enable_type_checks");
             }
             dartFlags.addAll(vmOptions);
           }
 
-          if (expectedOutput != null) {
-            if (expectedOutput.toNativePath().endsWith('.png')) {
-              // pixel tests are specified by running DRT "foo.html'-p"
-              contentShellOptions.add('--notree');
-              fullHtmlPath = "${fullHtmlPath}'-p";
-            }
-          }
           commandSet.add(CommandBuilder.instance.getContentShellCommand(
               contentShellFilename, fullHtmlPath, contentShellOptions,
-              dartFlags, expectedOutput, configurationDir));
+              dartFlags, configurationDir));
         }
 
         // Create BrowserTestCase and queue it.
         String testDisplayName = '$suiteName/$testName';
         var testCase;
         if (info.optionsFromFile['isMultiHtmlTest']) {
           testDisplayName = '$testDisplayName/${subtestNames[subtestIndex]}';
           testCase = new BrowserTestCase(testDisplayName,
               commandSet, configuration,
               expectations['$testName/${subtestNames[subtestIndex]}'],
@@ skipping 876 matching lines @@
  * $pass tests are expected to pass
  * $failOk tests are expected to fail that we won't fix
  * $fail tests are expected to fail that we should fix
  * $crash tests are expected to crash that we should fix
  * $timeout tests are allowed to timeout
  * $compileErrorSkip tests are skipped on browsers due to compile-time error
 """;
     print(report);
    }
 }