Get rid of two more warnings.

Get rid of two more warnings.

R=ahe@google.com

Committed: https://github.com/dart-lang/sdk/commit/64591376e794f6013887b88b477ad63956faba2d

[Siggi Cherem (dart-lang), 2017-02-15 22:05:12]

Description was changed from

==========
Get read of two more warnings.
==========

to

==========
Get rid of two more warnings.
==========

[Siggi Cherem (dart-lang), 2017-02-15 22:05:24]

sigmund@google.com changed reviewers:
+ ahe@google.com, paulberry@google.com

[Siggi Cherem (dart-lang), 2017-02-15 22:05:25]

https://codereview.chromium.org/2699743002/diff/1/pkg/front_end/lib/src/fasta...
File pkg/front_end/lib/src/fasta/kernel/kernel_library_builder.dart (right):

https://codereview.chromium.org/2699743002/diff/1/pkg/front_end/lib/src/fasta...
pkg/front_end/lib/src/fasta/kernel/kernel_library_builder.dart:350: void
includePart(covariant KernelLibraryBuilder part) {
happy to do it differently here, since the other covariant are still in use, we
can change them all at once.

[ahe, 2017-02-15 22:16:06]

It seems like strong mode and Dart mode has different implementations of dead
code. I'm not getting a warning about missing return, and there shouldn't be
one.

Which version of the analyzer are you using?

https://codereview.chromium.org/2699743002/diff/1/pkg/front_end/lib/src/fasta...
File pkg/front_end/lib/src/fasta/operator.dart (right):

https://codereview.chromium.org/2699743002/diff/1/pkg/front_end/lib/src/fasta...
pkg/front_end/lib/src/fasta/operator.dart:80: return null;
Why is this necessary?

[ahe, 2017-02-15 22:21:44]

LGTM

FWIW, I run the analyzer using this incantation:

dart pkg/testing/bin/testing.dart --config=pkg/front_end/test/fasta/testing.json
analyze --verbose

If you have any suggestions for how to change the command line options, please
let me know.

I did have to filter out some specific hints about unneeded casts, see
https://github.com/dart-lang/sdk/blob/master/pkg/testing/lib/src/analyze.dart

And that also explains why I don't see the missing return hints :-(

I don't understand what is going on here. I suggest you land this CL, but we
need to get this sorted.

[Siggi Cherem (dart-lang), 2017-02-15 22:29:24]

On 2017/02/15 22:21:44, ahe wrote:
> LGTM
> 
> FWIW, I run the analyzer using this incantation:
> 
> dart pkg/testing/bin/testing.dart
--config=pkg/front_end/test/fasta/testing.json
> analyze --verbose
> 
> If you have any suggestions for how to change the command line options, please
> let me know.
> 
will do I'll take a look.

> I did have to filter out some specific hints about unneeded casts, see
> https://github.com/dart-lang/sdk/blob/master/pkg/testing/lib/src/analyze.dart

thanks for the pointer - I was just about to start playing with this. I think if
we can specify the --options flag here, you might be able to run it without the
filter. I'll play with it today and let you know.

> 
> And that also explains why I don't see the missing return hints :-(
> 
> I don't understand what is going on here. I suggest you land this CL, but we
> need to get this sorted.

Agree, thanks Peter

[Siggi Cherem (dart-lang), 2017-02-15 22:30:27]

Description was changed from

==========
Get rid of two more warnings.
==========

to

==========
Get rid of two more warnings.

R=ahe@google.com

Committed:
https://github.com/dart-lang/sdk/commit/64591376e794f6013887b88b477ad63956faba2d
==========

[Siggi Cherem (dart-lang), 2017-02-15 22:30:29]

Committed patchset #1 (id:1) manually as
64591376e794f6013887b88b477ad63956faba2d (presubmit successful).

[Siggi Cherem (dart-lang), 2017-02-15 22:57:43]

On 2017/02/15 22:29:24, Siggi Cherem (dart-lang) wrote:
> On 2017/02/15 22:21:44, ahe wrote:
> > LGTM
> > 
> > FWIW, I run the analyzer using this incantation:
> > 
> > dart pkg/testing/bin/testing.dart
> --config=pkg/front_end/test/fasta/testing.json
> > analyze --verbose
> > 
> > If you have any suggestions for how to change the command line options,
please
> > let me know.
> > 
> will do I'll take a look.
> 
> > I did have to filter out some specific hints about unneeded casts, see
> >
https://github.com/dart-lang/sdk/blob/master/pkg/testing/lib/src/analyze.dart
> 
> thanks for the pointer - I was just about to start playing with this. I think
if
> we can specify the --options flag here, you might be able to run it without
the
> filter. I'll play with it today and let you know.
> 
> > 
> > And that also explains why I don't see the missing return hints :-(
> > 
> > I don't understand what is going on here. I suggest you land this CL, but we
> > need to get this sorted.
> 
> Agree, thanks Peter

Just sent you a CL to consume the .analysis_option file so that it matches what
people get in intelliJ, hope this helps make it all uniform.

[ahe, 2017-02-16 12:23:09]

On 2017/02/15 22:57:43, Siggi Cherem (dart-lang) wrote:
> Just sent you a CL to consume the .analysis_option file so that it matches
what
> people get in intelliJ, hope this helps make it all uniform.

That will help a lot. I run this command all the time to check for new warnings
and hints.