Don't call into WebRuntimeFeatures::enableSpeechInput()

Don't call into WebRuntimeFeatures::enableSpeechInput()

Also delete ENABLE_INPUT_SPEECH and kDisableSpeechInput.

I wanted to remove the 'input_speech' GYP variable, but unfortunately
it seems to be guarding (parts of?) the new speech recognition implementation
too.

BUG=223198
R=brettw@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=268646

[hans, 2014-05-05 21:04:32]

Please take a look.

[brettw, 2014-05-05 21:20:30]

Is there a TODO you can write above the GYP flag that shouldn't exist about
this? I think it will be pretty confusing to somebody looking at it.

[hans, 2014-05-05 21:30:56]

On 2014/05/05 21:20:30, brettw wrote:
> Is there a TODO you can write above the GYP flag that shouldn't exist about
> this? I think it will be pretty confusing to somebody looking at it.

+tommi

I'm not likely to look into straightening out the GYP flag myself. It should
probably be renamed/reworked somehow. I'm happy to put a TODO(tommi) on it, but
personally I'm just trying to delete some dead code here.

The flag seems to serve two purposes: I think iOS tries to use it to disable
everything speech related. Android uses it to disable the legacy x-webkit-speech
API, but it also uses it to exclude libspeex and libflac. Those are used by the
new Web Speech API, and Android implements that, but with a custom back-end that
doesn't use those libraries.

[tommi (sloooow) - chröme, 2014-05-06 10:22:41]

On 2014/05/05 21:30:56, hans wrote:
> On 2014/05/05 21:20:30, brettw wrote:
> > Is there a TODO you can write above the GYP flag that shouldn't exist about
> > this? I think it will be pretty confusing to somebody looking at it.
> 
> +tommi
> 
> I'm not likely to look into straightening out the GYP flag myself. It should
> probably be renamed/reworked somehow. I'm happy to put a TODO(tommi) on it,
but
> personally I'm just trying to delete some dead code here.
> 
> The flag seems to serve two purposes: I think iOS tries to use it to disable
> everything speech related. Android uses it to disable the legacy
x-webkit-speech
> API, but it also uses it to exclude libspeex and libflac. Those are used by
the
> new Web Speech API, and Android implements that, but with a custom back-end
that
> doesn't use those libraries.

Can you assign that TODO to tommyw?

[hans, 2014-05-06 15:00:52]

On 2014/05/06 10:22:41, tommi wrote:
> On 2014/05/05 21:30:56, hans wrote:
> > On 2014/05/05 21:20:30, brettw wrote:
> > > Is there a TODO you can write above the GYP flag that shouldn't exist
about
> > > this? I think it will be pretty confusing to somebody looking at it.
> > 
> > +tommi
> > 
> > I'm not likely to look into straightening out the GYP flag myself. It should
> > probably be renamed/reworked somehow. I'm happy to put a TODO(tommi) on it,
> but
> > personally I'm just trying to delete some dead code here.
> > 
> > The flag seems to serve two purposes: I think iOS tries to use it to disable
> > everything speech related. Android uses it to disable the legacy
> x-webkit-speech
> > API, but it also uses it to exclude libspeex and libflac. Those are used by
> the
> > new Web Speech API, and Android implements that, but with a custom back-end
> that
> > doesn't use those libraries.
> 
> Can you assign that TODO to tommyw?

Done.

brettw: Please take another look.

[brettw, 2014-05-06 17:13:23]

lgtm

[hans, 2014-05-06 17:26:15]

The CQ bit was checked by hans@chromium.org

[commit-bot: I haz the power, 2014-05-06 17:27:12]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/hans@chromium.org/269973003/40001

[hans, 2014-05-07 00:53:54]

Committed patchset #3 manually as r268646 (presubmit successful).