Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(704)

Unified Diff: trunk/src/mojo/services/public/cpp/view_manager/lib/view_tree_node.cc

Issue 269973002: Revert 268218 "Add support for mapping node tree on the client." (Closed) Base URL: svn://svn.chromium.org/chrome/
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: trunk/src/mojo/services/public/cpp/view_manager/lib/view_tree_node.cc
===================================================================
--- trunk/src/mojo/services/public/cpp/view_manager/lib/view_tree_node.cc (revision 268224)
+++ trunk/src/mojo/services/public/cpp/view_manager/lib/view_tree_node.cc (working copy)
@@ -118,8 +118,6 @@
if (parent_)
parent_->RemoveChild(this);
- if (manager_)
- ViewManagerPrivate(manager_).synchronizer()->DestroyViewTreeNode(id_);
}
void ViewTreeNode::AddObserver(ViewTreeNodeObserver* observer) {
@@ -131,15 +129,19 @@
}
void ViewTreeNode::AddChild(ViewTreeNode* child) {
- LocalAddChild(child);
- if (manager_)
- ViewManagerPrivate(manager_).synchronizer()->AddChild(child->id(), id_);
+ ScopedTreeNotifier notifier(child, child->parent(), this);
+ if (child->parent())
+ RemoveChildImpl(child, &child->parent_->children_);
+ children_.push_back(child);
+ child->parent_ = this;
+ ViewManagerPrivate(manager_).synchronizer()->AddChild(child->id(), id_);
}
void ViewTreeNode::RemoveChild(ViewTreeNode* child) {
- LocalRemoveChild(child);
- if (manager_)
- ViewManagerPrivate(manager_).synchronizer()->RemoveChild(child->id(), id_);
+ DCHECK_EQ(this, child->parent());
+ ScopedTreeNotifier(child, this, NULL);
+ RemoveChildImpl(child, &children_);
+ ViewManagerPrivate(manager_).synchronizer()->RemoveChild(child->id(), id_);
}
bool ViewTreeNode::Contains(ViewTreeNode* child) const {
@@ -150,23 +152,6 @@
return false;
}
-////////////////////////////////////////////////////////////////////////////////
-// ViewTreeNode, private:
-
-void ViewTreeNode::LocalAddChild(ViewTreeNode* child) {
- ScopedTreeNotifier notifier(child, child->parent(), this);
- if (child->parent())
- RemoveChildImpl(child, &child->parent_->children_);
- children_.push_back(child);
- child->parent_ = this;
-}
-
-void ViewTreeNode::LocalRemoveChild(ViewTreeNode* child) {
- DCHECK_EQ(this, child->parent());
- ScopedTreeNotifier(child, this, NULL);
- RemoveChildImpl(child, &children_);
-}
-
} // namespace view_manager
} // namespace services
} // namespace mojo

Powered by Google App Engine
This is Rietveld 408576698