Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Side by Side Diff: third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2D.h

Issue 2699713005: Fix missing finalizeFrame barriers in WebGL animations (Closed)
Patch Set: Comments + readability improvements Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2006, 2007, 2009, 2010, 2011, 2012 Apple Inc. All rights 2 * Copyright (C) 2006, 2007, 2009, 2010, 2011, 2012 Apple Inc. All rights
3 * reserved. 3 * reserved.
4 * 4 *
5 * Redistribution and use in source and binary forms, with or without 5 * Redistribution and use in source and binary forms, with or without
6 * modification, are permitted provided that the following conditions 6 * modification, are permitted provided that the following conditions
7 * are met: 7 * are met:
8 * 1. Redistributions of source code must retain the above copyright 8 * 1. Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * 2. Redistributions in binary form must reproduce the above copyright 10 * 2. Redistributions in binary form must reproduce the above copyright
(...skipping 174 matching lines...) Expand 10 before | Expand all | Expand 10 after
185 void snapshotStateForFilter() final; 185 void snapshotStateForFilter() final;
186 186
187 void validateStateStack() const final; 187 void validateStateStack() const final;
188 188
189 PassRefPtr<Image> getImage(AccelerationHint, SnapshotReason) const final; 189 PassRefPtr<Image> getImage(AccelerationHint, SnapshotReason) const final;
190 190
191 bool isAccelerationOptimalForCanvasContent() const; 191 bool isAccelerationOptimalForCanvasContent() const;
192 192
193 void resetUsageTracking(); 193 void resetUsageTracking();
194 194
195 void incrementFrameCount() { m_usageCounters.numFramesSinceReset++; } 195 void finalizeFrame() override { m_usageCounters.numFramesSinceReset++; }
196 196
197 bool isPaintable() const final { return hasImageBuffer(); } 197 bool isPaintable() const final { return hasImageBuffer(); }
198 198
199 ColorBehavior drawImageColorBehavior() const final; 199 ColorBehavior drawImageColorBehavior() const final;
200 200
201 void willDrawImage(CanvasImageSource*) const final; 201 void willDrawImage(CanvasImageSource*) const final;
202 202
203 private: 203 private:
204 friend class CanvasRenderingContext2DAutoRestoreSkCanvas; 204 friend class CanvasRenderingContext2DAutoRestoreSkCanvas;
205 205
(...skipping 53 matching lines...) Expand 10 before | Expand all | Expand 10 after
259 259
260 DEFINE_TYPE_CASTS(CanvasRenderingContext2D, 260 DEFINE_TYPE_CASTS(CanvasRenderingContext2D,
261 CanvasRenderingContext, 261 CanvasRenderingContext,
262 context, 262 context,
263 context->is2d() && context->canvas(), 263 context->is2d() && context->canvas(),
264 context.is2d() && context.canvas()); 264 context.is2d() && context.canvas());
265 265
266 } // namespace blink 266 } // namespace blink
267 267
268 #endif // CanvasRenderingContext2D_h 268 #endif // CanvasRenderingContext2D_h
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698