Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(67)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2699713003: [WIP] RespondWithObserver

Created:
3 years, 10 months ago by zino
Modified:
3 years, 7 months ago
Reviewers:
tommyt
CC:
chromium-reviews, michaeln, jsbell+serviceworker_chromium.org, shimazu+serviceworker_chromium.org, serviceworker-reviews, nhiroki, blink-reviews, kinuko+serviceworker, haraken, horo+watch_chromium.org, falken+watch_chromium.org, tzik
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

RespondWithObserver BUG=

Patch Set 1 #

Patch Set 2 : RespondWithObserver #

Patch Set 3 : RespondWithObserver #

Patch Set 4 : RespondWithObserver #

Patch Set 5 : RespondWithObserver #

Patch Set 6 : RespondWithObserver #

Patch Set 7 : RespondWithObserver #

Unified diffs Side-by-side diffs Delta from patch set Stats (+412 lines, -429 lines) Patch
M third_party/WebKit/Source/modules/modules_idl_files.gni View 1 2 3 5 6 2 chunks +3 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/modules/payments/PaymentAppResponse.idl View 1 4 1 chunk +10 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/payments/PaymentRequestEvent.h View 1 2 3 4 5 6 2 chunks +6 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/payments/PaymentRequestEvent.cpp View 1 2 3 4 5 6 3 chunks +21 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/modules/payments/PaymentRequestEvent.idl View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/serviceworkers/BUILD.gn View 1 2 3 4 5 2 chunks +4 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/serviceworkers/DEPS View 1 2 3 4 5 6 1 chunk +1 line, -0 lines 0 comments Download
A third_party/WebKit/Source/modules/serviceworkers/FetchRespondWithObserver.h View 1 2 3 4 5 6 1 chunk +61 lines, -0 lines 0 comments Download
A + third_party/WebKit/Source/modules/serviceworkers/FetchRespondWithObserver.cpp View 1 2 3 4 5 6 8 chunks +28 lines, -113 lines 0 comments Download
M third_party/WebKit/Source/modules/serviceworkers/ForeignFetchRespondWithObserver.h View 1 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/serviceworkers/ForeignFetchRespondWithObserver.cpp View 1 2 3 4 2 chunks +9 lines, -9 lines 0 comments Download
A third_party/WebKit/Source/modules/serviceworkers/PaymentRequestRespondWithObserver.h View 1 2 3 4 5 6 1 chunk +43 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/modules/serviceworkers/PaymentRequestRespondWithObserver.cpp View 1 2 3 4 5 6 1 chunk +136 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/serviceworkers/RespondWithObserver.h View 1 2 3 4 5 6 3 chunks +10 lines, -31 lines 0 comments Download
M third_party/WebKit/Source/modules/serviceworkers/RespondWithObserver.cpp View 1 2 3 4 5 6 5 chunks +12 lines, -255 lines 0 comments Download
M third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerGlobalScopeClient.h View 1 2 3 4 5 6 2 chunks +4 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/web/ServiceWorkerGlobalScopeClientImpl.h View 1 2 3 4 5 6 2 chunks +4 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/web/ServiceWorkerGlobalScopeClientImpl.cpp View 1 2 3 4 5 6 2 chunks +10 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/web/ServiceWorkerGlobalScopeProxy.cpp View 1 2 3 4 5 6 5 chunks +21 lines, -6 lines 0 comments Download
M third_party/WebKit/public/BUILD.gn View 1 2 3 4 5 6 1 chunk +1 line, -0 lines 0 comments Download
A third_party/WebKit/public/platform/modules/payments/WebPaymentAppResponse.h View 1 2 3 4 5 1 chunk +20 lines, -0 lines 0 comments Download
M third_party/WebKit/public/web/modules/serviceworker/WebServiceWorkerContextClient.h View 1 2 3 4 5 6 2 chunks +5 lines, -0 lines 0 comments Download

Messages

Total messages: 23 (23 generated)
zino
Description was changed from ========== RespondWithObserver BUG= ========== to ========== RespondWithObserver BUG= ==========
3 years, 10 months ago (2017-02-16 12:02:14 UTC) #1
zino
The CQ bit was checked by jinho.bang@samsung.com to run a CQ dry run
3 years, 10 months ago (2017-02-19 13:53:11 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2699713003/20001
3 years, 10 months ago (2017-02-19 13:53:26 UTC) #3
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 10 months ago (2017-02-19 14:37:35 UTC) #4
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_tsan_rel_ng/builds/18055)
3 years, 10 months ago (2017-02-19 14:37:36 UTC) #5
zino
The CQ bit was checked by jinho.bang@samsung.com to run a CQ dry run
3 years, 10 months ago (2017-02-19 15:36:56 UTC) #6
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2699713003/40001
3 years, 10 months ago (2017-02-19 15:37:05 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 10 months ago (2017-02-19 15:45:14 UTC) #8
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_tsan_rel_ng/builds/18061) mac_chromium_compile_dbg_ng on ...
3 years, 10 months ago (2017-02-19 15:45:16 UTC) #9
zino
The CQ bit was checked by jinho.bang@samsung.com to run a CQ dry run
3 years, 10 months ago (2017-02-20 05:32:20 UTC) #10
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2699713003/60001
3 years, 10 months ago (2017-02-20 05:32:29 UTC) #11
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 10 months ago (2017-02-20 06:40:25 UTC) #12
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/391610)
3 years, 10 months ago (2017-02-20 06:40:26 UTC) #13
zino
The CQ bit was checked by jinho.bang@samsung.com to run a CQ dry run
3 years, 10 months ago (2017-02-20 13:57:36 UTC) #14
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2699713003/80001
3 years, 10 months ago (2017-02-20 13:57:56 UTC) #15
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 10 months ago (2017-02-20 16:32:04 UTC) #16
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
3 years, 10 months ago (2017-02-20 16:32:05 UTC) #17
zino
jinho.bang@samsung.com changed reviewers: + nhiroki@chromium.org, tommyt@opera.com
3 years, 10 months ago (2017-02-21 06:34:03 UTC) #18
zino
The CQ bit was checked by jinho.bang@samsung.com to run a CQ dry run
3 years, 10 months ago (2017-02-23 07:43:29 UTC) #19
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2699713003/120001
3 years, 10 months ago (2017-02-23 07:43:42 UTC) #20
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 10 months ago (2017-02-23 09:15:18 UTC) #21
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
3 years, 10 months ago (2017-02-23 09:15:19 UTC) #22
nhiroki
3 years, 7 months ago (2017-05-11 05:04:37 UTC) #23

Powered by Google App Engine
This is Rietveld 408576698