Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(468)

Unified Diff: third_party/WebKit/Source/core/layout/LayoutMultiColumnSet.cpp

Issue 2699653002: Avoid over-eager clipping of child layers in multicol. (Closed)
Patch Set: Add test that demonstrates what is now fixed in the rebaselined border-antialiasing.html Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/LayoutTests/platform/win7/fast/borders/border-antialiasing-expected.png ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/layout/LayoutMultiColumnSet.cpp
diff --git a/third_party/WebKit/Source/core/layout/LayoutMultiColumnSet.cpp b/third_party/WebKit/Source/core/layout/LayoutMultiColumnSet.cpp
index ddc5cd2b29b0e6185ae87085e3e785bca94a046a..b19b878a879f36805f9c17b204afd72526608803 100644
--- a/third_party/WebKit/Source/core/layout/LayoutMultiColumnSet.cpp
+++ b/third_party/WebKit/Source/core/layout/LayoutMultiColumnSet.cpp
@@ -312,37 +312,20 @@ LayoutRect LayoutMultiColumnSet::overflowRectForFlowThreadPortion(
const LayoutRect& flowThreadPortionRect,
bool isFirstPortion,
bool isLastPortion) const {
- if (hasOverflowClip())
- return flowThreadPortionRect;
+ // Only clip along the block direction axis.
+ LayoutRect clipRect(LayoutRect::infiniteIntRect());
- LayoutRect flowThreadOverflow = m_flowThread->visualOverflowRect();
-
- // Only clip along the flow thread axis.
- LayoutRect clipRect;
if (m_flowThread->isHorizontalWritingMode()) {
- LayoutUnit minY =
- isFirstPortion ? flowThreadOverflow.y() : flowThreadPortionRect.y();
- LayoutUnit maxY = isLastPortion ? std::max(flowThreadPortionRect.maxY(),
- flowThreadOverflow.maxY())
- : flowThreadPortionRect.maxY();
- LayoutUnit minX =
- std::min(flowThreadPortionRect.x(), flowThreadOverflow.x());
- LayoutUnit maxX =
- std::max(flowThreadPortionRect.maxX(), flowThreadOverflow.maxX());
- clipRect = LayoutRect(minX, minY, maxX - minX, maxY - minY);
- } else {
- LayoutUnit minX =
- isFirstPortion ? flowThreadOverflow.x() : flowThreadPortionRect.x();
- LayoutUnit maxX = isLastPortion ? std::max(flowThreadPortionRect.maxX(),
- flowThreadOverflow.maxX())
- : flowThreadPortionRect.maxX();
- LayoutUnit minY =
- std::min(flowThreadPortionRect.y(), (flowThreadOverflow.y()));
- LayoutUnit maxY =
- std::max(flowThreadPortionRect.y(), (flowThreadOverflow.maxY()));
- clipRect = LayoutRect(minX, minY, maxX - minX, maxY - minY);
+ if (!isFirstPortion)
+ clipRect.shiftYEdgeTo(flowThreadPortionRect.y());
+ if (!isLastPortion)
+ clipRect.shiftMaxYEdgeTo(flowThreadPortionRect.maxY());
+ return clipRect;
}
-
+ if (!isFirstPortion)
+ clipRect.shiftXEdgeTo(flowThreadPortionRect.x());
+ if (!isLastPortion)
+ clipRect.shiftMaxXEdgeTo(flowThreadPortionRect.maxX());
return clipRect;
}
« no previous file with comments | « third_party/WebKit/LayoutTests/platform/win7/fast/borders/border-antialiasing-expected.png ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698