chrome/android/java/strings/android_chrome_strings.grd - Issue 2699643003: Show an infobar when VR services need to be installed or updated.

Side by Side Diff: chrome/android/java/strings/android_chrome_strings.grd

Issue 2699643003: Show an infobar when VR services need to be installed or updated. (Closed)

Patch Set: Updated button text resources and adjusted version check. Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellDelegate.java ('k') | components/infobars/core/infobar_delegate.h » ('j') | components/infobars/core/infobar_delegate.h » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <?xml version="1.0" encoding="UTF-8"?>	1 <?xml version="1.0" encoding="UTF-8"?>

2	2

3 <!-- android_chrome_strings.grd contains strings for Chrome for Android.	3 <!-- android_chrome_strings.grd contains strings for Chrome for Android.

4	4

5 FAQ:	5 FAQ:

6 - How do I add, change, or remove a string?	6 - How do I add, change, or remove a string?

7 Just update this file.	7 Just update this file.

8 - Translations will happen automatically??	8 - Translations will happen automatically??

9 Yes, indeed. Just add your string before the branch point and	9 Yes, indeed. Just add your string before the branch point and

10 make the description good.	10 make the description good.

(...skipping 2720 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
2731 </message>	2731 </message>

2732 <message name="IDS_KEYBOARD_SHORTCUT_TAB_GROUP_HEADER" desc="A text label that appears above a list of shortcuts that are related to the tab window. This group is part of several groups of keyboard shortcuts all shown in a dialog.">	2732 <message name="IDS_KEYBOARD_SHORTCUT_TAB_GROUP_HEADER" desc="A text label that appears above a list of shortcuts that are related to the tab window. This group is part of several groups of keyboard shortcuts all shown in a dialog.">

2733 Tab and window shortcuts	2733 Tab and window shortcuts

2734 </message>	2734 </message>

2735 <message name="IDS_KEYBOARD_SHORTCUT_CHROME_FEATURE_GROUP_HEADER" desc="A text label that appears above a list of shortcuts that are related to the Chrome app features. This group is part of several groups of keyboard shortcuts all sh own in a dialog.">	2735 <message name="IDS_KEYBOARD_SHORTCUT_CHROME_FEATURE_GROUP_HEADER" desc="A text label that appears above a list of shortcuts that are related to the Chrome app features. This group is part of several groups of keyboard shortcuts all sh own in a dialog.">

2736 Google Chrome feature shortcuts	2736 Google Chrome feature shortcuts

2737 </message>	2737 </message>

2738 <message name="IDS_KEYBOARD_SHORTCUT_WEBPAGE_GROUP_HEADER" desc="A text la bel that appears above a list of shortcuts that are related to manipulation of t he current tab window. This group is part of several groups of keyboard shortcut s all shown in a dialog.">	2738 <message name="IDS_KEYBOARD_SHORTCUT_WEBPAGE_GROUP_HEADER" desc="A text la bel that appears above a list of shortcuts that are related to manipulation of t he current tab window. This group is part of several groups of keyboard shortcut s all shown in a dialog.">

2739 Webpage shortcuts	2739 Webpage shortcuts

2740 </message>	2740 </message>

	2741

	2742 <!-- VR services check infobar -->

	2743 <message name="IDS_VR_SERVICES_CHECK_INFOBAR_TEXT" desc="Text to displayed in the VR Services check infobar.">
	Peter Kasting 2017/02/17 02:34:49 Nit: What is the "VR services check infobar"? Mak Nit: What is the "VR services check infobar"? Make sure to write this message text for a translator who knows nothing about the product and can't see screenshots, so it has to give context of what the user is doing and what the infobar is trying to ask them to do. amp 2017/02/17 02:52:29 Done. Show quoted text On 2017/02/17 02:34:49, Peter Kasting wrote: > Nit: What is the "VR services check infobar"? Make sure to write this message > text for a translator who knows nothing about the product and can't see > screenshots, so it has to give context of what the user is doing and what the > infobar is trying to ask them to do. Done.
	2744 To view virtual reality content, <ph name="ACTION">%s<ex>install</ex></p h> Google VR Services

	2745 </message>

	2746 <message name="IDS_VR_SERVICES_CHECK_INFOBAR_INSTALL_ACTION" desc="Text to be displayed in the VR Services check infobar text for the install action">
	Peter Kasting 2017/02/17 02:34:49 Nit: It wasn't immediately clear to me that this g Nit: It wasn't immediately clear to me that this gets substituted into the sentence above, or what the conditions are when users would see this text versus the below text. Make sure to spell out these details clearly. amp 2017/02/17 02:52:29 Done. Show quoted text On 2017/02/17 02:34:49, Peter Kasting wrote: > Nit: It wasn't immediately clear to me that this gets substituted into the > sentence above, or what the conditions are when users would see this text versus > the below text. Make sure to spell out these details clearly. Done.
	2747 install

	2748 </message>

	2749 <message name="IDS_VR_SERVICES_CHECK_INFOBAR_UPDATE_ACTION" desc="Text to be displayed in the VR Services check infobar text for the update action">

	2750 update

	2751 </message>

	2752 <message name="IDS_VR_SERVICES_CHECK_INFOBAR_INSTALL_BUTTON" desc="Text to be displayed in the VR Services check infobar confirm button for the install ac tion">
	Peter Kasting 2017/02/17 02:34:49 Nit: If this needs to follow a certain capitalizat Nit: If this needs to follow a certain capitalization scheme or something, that needs to be stated explicitly here. amp 2017/02/17 02:52:29 I initially just had two messages here, but per ba Show quoted text On 2017/02/17 02:34:49, Peter Kasting wrote: > Nit: If this needs to follow a certain capitalization scheme or something, that > needs to be stated explicitly here. I initially just had two messages here, but per bauerb@ and https://material.io/guidelines/components/buttons.html#buttons-style they are supposed to be capitalized for all translations. I added a reference in the description.
	2753 INSTALL

	2754 </message>

	2755 <message name="IDS_VR_SERVICES_CHECK_INFOBAR_UPDATE_BUTTON" desc="Text to be displayed in the VR Services check infobar confirm button for the update acti on">

	2756 UPDATE

	2757 </message>

2741 </messages>	2758 </messages>

2742 </release>	2759 </release>

2743 </grit>	2760 </grit>

OLD	NEW