components/ntp_snippets/remote/scheduling_remote_suggestions_provider.h - Issue 2699613002: [remote suggestions] Add separte fetch interval for NTP open trigger

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/ntp_snippets/remote/scheduling_remote_suggestions_provider.h

Issue 2699613002: [remote suggestions] Add separte fetch interval for NTP open trigger (Closed)

Patch Set: Address comments Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/ntp_snippets/pref_names.cc ('k') | components/ntp_snippets/remote/scheduling_remote_suggestions_provider.cc » ('j') | components/ntp_snippets/remote/scheduling_remote_suggestions_provider_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/ntp_snippets/remote/scheduling_remote_suggestions_provider.h

diff --git a/components/ntp_snippets/remote/scheduling_remote_suggestions_provider.h b/components/ntp_snippets/remote/scheduling_remote_suggestions_provider.h

index 7a42b470380d3f19fd62a980ab963c62045d6e47..d0639cbdb97fc33a99b1ea3babd86b20dd5102ae 100644

--- a/components/ntp_snippets/remote/scheduling_remote_suggestions_provider.h

+++ b/components/ntp_snippets/remote/scheduling_remote_suggestions_provider.h

@@ -114,6 +114,7 @@ class SchedulingRemoteSuggestionsProvider final

base::TimeDelta interval_persistent_wifi;

base::TimeDelta interval_persistent_fallback;

base::TimeDelta interval_soft_on_usage_event;

+ base::TimeDelta interval_soft_on_ntp_opened;

};

enum class TriggerType;

@@ -137,7 +138,7 @@ class SchedulingRemoteSuggestionsProvider final

// Checks whether it is time to perform a soft background fetch, according to

// |schedule|.

- bool ShouldRefetchInTheBackgroundNow();

+ bool ShouldRefetchInTheBackgroundNow(TriggerType trigger);

// Returns whether background fetching (for the given |trigger|) is disabled.

bool BackgroundFetchesDisabled(TriggerType trigger) const;