[remote suggestions] Add separte fetch interval for NTP open trigger

components/ntp_snippets/remote/scheduling_remote_suggestions_provider.h

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef COMPONENTS_NTP_SNIPPETS_REMOTE_SCHEDULING_REMOTE_SUGGESTIONS_PROVIDER_H_
 #define COMPONENTS_NTP_SNIPPETS_REMOTE_SCHEDULING_REMOTE_SUGGESTIONS_PROVIDER_H_
 
 #include <memory>
 #include <set>
 #include <string>
@@ skipping 96 matching lines @@
   // Abstract description of the fetching schedule.
   struct FetchingSchedule {
       static FetchingSchedule Empty();
       bool operator==(const FetchingSchedule& other) const;
       bool operator!=(const FetchingSchedule& other) const;
       bool is_empty() const;
 
       base::TimeDelta interval_persistent_wifi;
       base::TimeDelta interval_persistent_fallback;
       base::TimeDelta interval_soft_on_usage_event;
+      base::TimeDelta interval_ntp_open;

[jkrcal, 2017/02/15 16:35:34]

nit: can it be soft_on_ntp_opened?
 (opened to make it consistent with the event name; soft_ because it is soft as
well)

Another possibility is to make it more abstract:
  soft_on_priority_usage_event
I think it actually better expresses the core of being a separate interval.

WDYT?

[markusheintz_, 2017/02/15 21:19:29]

soft_on_ntp_opened SGTM. 

Name updated.

   };
 
   enum class TriggerType;
 
   // Callback that is notified whenever the status of |provider_| changes.
   void OnProviderStatusChanged(
       RemoteSuggestionsProvider::ProviderStatus status);
 
   // After the call, updates will be scheduled in the future. Idempotent, can be
   // run any time later without impacting the current schedule.
   // If you want to enforce rescheduling, call Unschedule() and then Schedule().
   void StartScheduling();
 
   // After the call, no updates will happen before another call to Schedule().
   // Idempotent, can be run any time later without impacting the current
   // schedule.
   void StopScheduling();
 
   // Trigger a background refetch for the given |trigger| if enabled.
   void RefetchInTheBackgroundIfEnabled(TriggerType trigger);
 
   // Checks whether it is time to perform a soft background fetch, according to
   // |schedule|.
-  bool ShouldRefetchInTheBackgroundNow();
+  bool ShouldRefetchInTheBackgroundNow(TriggerType trigger);
 
   // Returns whether background fetching (for the given |trigger|) is disabled.
   bool BackgroundFetchesDisabled(TriggerType trigger) const;
 
   // Callback after Fetch is completed.
   void FetchFinished(const FetchDoneCallback& callback,
                      Status fetch_status,
                      std::vector<ContentSuggestion> suggestions);
 
   // Callback after RefetchInTheBackground is completed.
@@ skipping 35 matching lines @@
   PrefService* pref_service_;
   std::unique_ptr<base::Clock> clock_;
   std::set<SchedulingRemoteSuggestionsProvider::TriggerType> enabled_triggers_;
 
   DISALLOW_COPY_AND_ASSIGN(SchedulingRemoteSuggestionsProvider);
 };
 
 }  // namespace ntp_snippets
 
 #endif  // COMPONENTS_NTP_SNIPPETS_REMOTE_SCHEDULING_REMOTE_SUGGESTIONS_PROVIDER_H_