Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 269953006: [DevTools] Don't show UI for unavailable overrides. (Closed)

Created:
6 years, 7 months ago by dgozman
Modified:
6 years, 7 months ago
Reviewers:
pfeldman
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

[DevTools] Don't show UI for unavailable overrides. BUG=353980 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=173644

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -10 lines) Patch
M Source/devtools/front_end/elements/OverridesView.js View 2 chunks +9 lines, -3 lines 0 comments Download
M Source/devtools/front_end/sdk/OverridesSupport.js View 6 chunks +22 lines, -7 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
dgozman
Could you please take a look?
6 years, 7 months ago (2014-05-06 11:43:16 UTC) #1
pfeldman
6 years, 7 months ago (2014-05-07 16:01:47 UTC) #2
dgozman
ping
6 years, 7 months ago (2014-05-08 05:07:26 UTC) #3
pfeldman
lgtm
6 years, 7 months ago (2014-05-08 10:23:32 UTC) #4
dgozman
The CQ bit was checked by dgozman@chromium.org
6 years, 7 months ago (2014-05-08 11:08:29 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/269953006/1
6 years, 7 months ago (2014-05-08 11:09:21 UTC) #6
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-08 11:51:37 UTC) #7
commit-bot: I haz the power
6 years, 7 months ago (2014-05-08 13:02:10 UTC) #8
Message was sent while issue was closed. 
Change committed as 173644

Powered by Google App Engine
This is Rietveld 408576698