Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2128)

Unified Diff: build/config/BUILDCONFIG.gn

Issue 2699473002: Reland of Android: Use linker script to hide all non-JNI symbols (Closed)
Patch Set: fix loadable_module Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « build/android/android_only_jni_exports.lst ('k') | build/config/android/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/config/BUILDCONFIG.gn
diff --git a/build/config/BUILDCONFIG.gn b/build/config/BUILDCONFIG.gn
index edefb2c6ced883c0d4a8a3e40089cf9b4c6ddf82..d055e705627c96782434537d0157594ff4f6dad0 100644
--- a/build/config/BUILDCONFIG.gn
+++ b/build/config/BUILDCONFIG.gn
@@ -568,16 +568,19 @@ default_shared_library_configs = default_compiler_configs + [
if (is_android) {
# Strip native JNI exports from shared libraries by default. Binaries that
# want this can remove this config.
- default_shared_library_configs += [
- "//build/config/android:hide_native_jni_exports",
- "//build/config/android:hide_all_but_jni_onload",
- ]
+ default_shared_library_configs +=
+ [ "//build/config/android:hide_all_but_jni_onload" ]
}
set_defaults("shared_library") {
configs = default_shared_library_configs
}
set_defaults("loadable_module") {
configs = default_shared_library_configs
+
+ # loadable_modules are generally used by other libs, not just via JNI.
+ if (is_android) {
+ configs -= [ "//build/config/android:hide_all_but_jni_onload" ]
+ }
}
# ==============================================================================
@@ -649,10 +652,7 @@ set_defaults("component") {
if (is_component_build) {
configs = default_shared_library_configs
if (is_android) {
- configs -= [
- "//build/config/android:hide_native_jni_exports",
- "//build/config/android:hide_all_but_jni_onload",
- ]
+ configs -= [ "//build/config/android:hide_all_but_jni_onload" ]
}
} else {
configs = default_compiler_configs
« no previous file with comments | « build/android/android_only_jni_exports.lst ('k') | build/config/android/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698