Fix gradient background invalidation when HTML size changes

third_party/WebKit/Source/core/paint/BoxPaintInvalidatorTest.cpp

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "core/HTMLNames.h"
 #include "core/frame/FrameView.h"
 #include "core/layout/LayoutTestHelper.h"
 #include "core/layout/LayoutView.h"
 #include "core/paint/PaintLayer.h"
 #include "platform/graphics/GraphicsLayer.h"
@@ skipping 15 matching lines @@
     // TODO(wangxianzhu): Test SPv2.
     return layoutView()
         .layer()
         ->graphicsLayerBacking()
         ->getRasterInvalidationTracking();
   }
 
  private:
   void SetUp() override {
     RenderingTest::SetUp();
+    document().setCompatibilityMode(Document::NoQuirksMode);
     enableCompositing();
     setBodyInnerHTML(
         "<style>"
         "  body {"
         "    margin: 0;"
         "    height: 0;"
         "  }"
         "  ::-webkit-scrollbar { display: none }"
         "  #target {"
         "    width: 50px;"
@@ skipping 181 matching lines @@
   target->setAttribute(HTMLNames::classAttr, "");
   target->setAttribute(HTMLNames::styleAttr, "height: 2000px");
   document().view()->updateAllLifecyclePhases();
 
   // Resize the content.
   document().view()->setTracksPaintInvalidations(true);
   target->setAttribute(HTMLNames::styleAttr, "height: 3000px");
   document().view()->updateAllLifecyclePhases();
   const auto& rasterInvalidations =
       getRasterInvalidationTracking()->trackedRasterInvalidations;
-  // TODO(wangxianzhu): Temporary for crbug.com/680745.
-  // ASSERT_EQ(1u, rasterInvalidations.size());
-  ASSERT_EQ(2u, rasterInvalidations.size());
+  ASSERT_EQ(1u, rasterInvalidations.size());
   EXPECT_EQ(IntRect(0, 2000, 800, 1000), rasterInvalidations[0].rect);
   EXPECT_EQ(static_cast<const DisplayItemClient*>(&layoutView()),
             rasterInvalidations[0].client);
   if (RuntimeEnabledFeatures::rootLayerScrollingEnabled()) {
     EXPECT_EQ(PaintInvalidationBackgroundOnScrollingContentsLayer,
               rasterInvalidations[0].reason);
   } else {
     EXPECT_EQ(PaintInvalidationIncremental, rasterInvalidations[0].reason);
   }
 
@@ skipping 15 matching lines @@
   target->setAttribute(HTMLNames::styleAttr, "height: 2000px");
   document().view()->updateAllLifecyclePhases();
 
   // Resize the content.
   document().view()->setTracksPaintInvalidations(true);
   target->setAttribute(HTMLNames::styleAttr, "height: 3000px");
   document().view()->updateAllLifecyclePhases();
 
   const auto& rasterInvalidations =
       getRasterInvalidationTracking()->trackedRasterInvalidations;
-  // TODO(wangxianzhu): Temporary for crbug.com/680745.
-  // ASSERT_EQ(1u, rasterInvalidations.size());
-  ASSERT_EQ(2u, rasterInvalidations.size());
+  ASSERT_EQ(1u, rasterInvalidations.size());
   EXPECT_EQ(IntRect(0, 0, 800, 3000), rasterInvalidations[0].rect);
   EXPECT_EQ(static_cast<const DisplayItemClient*>(&layoutView()),
             rasterInvalidations[0].client);
   if (RuntimeEnabledFeatures::rootLayerScrollingEnabled()) {
     EXPECT_EQ(PaintInvalidationBackgroundOnScrollingContentsLayer,
               rasterInvalidations[0].reason);
   } else {
     EXPECT_EQ(PaintInvalidationLayoutOverflowBoxChange,
               rasterInvalidations[0].reason);
   }
@@ skipping 25 matching lines @@
   Element* iframe = document().getElementById("iframe");
   Element* content = childDocument().getElementById("content");
   EXPECT_EQ(layoutView(),
             content->layoutObject()->containerForPaintInvalidation());
 
   // Resize the content.
   document().view()->setTracksPaintInvalidations(true);
   content->setAttribute(HTMLNames::styleAttr, "height: 500px");
   document().view()->updateAllLifecyclePhases();
   // No invalidation because the changed part of layout overflow is clipped.
-  // TODO(wangxianzhu): Temporary for crbug.com/680745.
-  // EXPECT_FALSE(getRasterInvalidationTracking());
-  EXPECT_EQ(1u,
-            getRasterInvalidationTracking()->trackedRasterInvalidations.size());
+  EXPECT_FALSE(getRasterInvalidationTracking());
   document().view()->setTracksPaintInvalidations(false);
 
   // Resize the iframe.
   document().view()->setTracksPaintInvalidations(true);
   iframe->setAttribute(HTMLNames::styleAttr, "height: 200px");
   document().view()->updateAllLifecyclePhases();
   const auto& rasterInvalidations =
       getRasterInvalidationTracking()->trackedRasterInvalidations;
   ASSERT_EQ(2u, rasterInvalidations.size());
   EXPECT_EQ(IntRect(0, 100, 100, 100), rasterInvalidations[0].rect);
@@ skipping 38 matching lines @@
   LayoutView* frameLayoutView = content->layoutObject()->view();
   EXPECT_EQ(layoutView(),
             content->layoutObject()->containerForPaintInvalidation());
 
   // Resize the content.
   document().view()->setTracksPaintInvalidations(true);
   content->setAttribute(HTMLNames::styleAttr, "height: 500px");
   document().view()->updateAllLifecyclePhases();
   const auto* rasterInvalidations =
       &getRasterInvalidationTracking()->trackedRasterInvalidations;
-  // TODO(wangxianzhu): Temporary for crbug.com/680745.
-  // ASSERT_EQ(1u, rasterInvalidations->size());
-  ASSERT_EQ(2u, rasterInvalidations->size());
+  ASSERT_EQ(1u, rasterInvalidations->size());
   EXPECT_EQ(IntRect(0, 0, 100, 100), (*rasterInvalidations)[0].rect);
   EXPECT_EQ(static_cast<const DisplayItemClient*>(frameLayoutView),
             (*rasterInvalidations)[0].client);
   EXPECT_EQ(PaintInvalidationLayoutOverflowBoxChange,
             (*rasterInvalidations)[0].reason);
   document().view()->setTracksPaintInvalidations(false);
 
   // Resize the iframe.
   document().view()->setTracksPaintInvalidations(true);
   iframe->setAttribute(HTMLNames::styleAttr, "height: 200px");
   document().view()->updateAllLifecyclePhases();
   rasterInvalidations =
       &getRasterInvalidationTracking()->trackedRasterInvalidations;
   ASSERT_EQ(2u, rasterInvalidations->size());
   EXPECT_EQ(IntRect(0, 100, 100, 100), (*rasterInvalidations)[0].rect);
   EXPECT_EQ(static_cast<const DisplayItemClient*>(iframe->layoutObject()),
             (*rasterInvalidations)[0].client);
   EXPECT_EQ(PaintInvalidationIncremental, (*rasterInvalidations)[0].reason);
   EXPECT_EQ(static_cast<const DisplayItemClient*>(frameLayoutView),
             (*rasterInvalidations)[1].client);
   EXPECT_EQ(IntRect(0, 0, 100, 200), (*rasterInvalidations)[1].rect);
   if (RuntimeEnabledFeatures::rootLayerScrollingEnabled()) {
     // TODO(skobes): Treat LayoutView in the same way as normal objects having
     // background-attachment: local. crbug.com/568847.
     EXPECT_EQ(PaintInvalidationFull, (*rasterInvalidations)[1].reason);
   } else {
-    EXPECT_EQ(PaintInvalidationBorderBoxChange,
+    EXPECT_EQ(PaintInvalidationViewBackground,
               (*rasterInvalidations)[1].reason);
   }
   document().view()->setTracksPaintInvalidations(false);
 }
 
 TEST_P(BoxPaintInvalidatorTest, CompositedBackgroundAttachmentLocalResize) {
   enableCompositing();
 
   Element* target = document().getElementById("target");
   target->setAttribute(HTMLNames::classAttr, "border local-background");
@@ skipping 130 matching lines @@
       getRasterInvalidationTracking()->trackedRasterInvalidations;
   ASSERT_EQ(1u, rasterInvalidations.size());
   EXPECT_EQ(IntRect(0, 120, 70, 120), rasterInvalidations[0].rect);
   EXPECT_EQ(static_cast<const DisplayItemClient*>(target->layoutObject()),
             rasterInvalidations[0].client);
   EXPECT_EQ(PaintInvalidationIncremental, rasterInvalidations[0].reason);
   document().view()->setTracksPaintInvalidations(false);
 }
 
 }  // namespace blink