Fix gradient background invalidation when HTML size changes

third_party/WebKit/Source/core/layout/LayoutView.cpp

 /*
  * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
  * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009 Apple Inc.
  *               All rights reserved.
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Library General Public
  * License as published by the Free Software Foundation; either
  * version 2 of the License, or (at your option) any later version.
  *
  * This library is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
  * Library General Public License for more details.
  *
  * You should have received a copy of the GNU Library General Public License
  * along with this library; see the file COPYING.LIB.  If not, write to
  * the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor,
  * Boston, MA 02110-1301, USA.
  */
 
 #include "core/layout/LayoutView.h"
 
+#include <inttypes.h>
 #include "core/dom/Document.h"
 #include "core/dom/Element.h"
 #include "core/editing/FrameSelection.h"
 #include "core/frame/FrameView.h"
 #include "core/frame/LocalFrame.h"
 #include "core/frame/Settings.h"
 #include "core/html/HTMLIFrameElement.h"
 #include "core/layout/HitTestResult.h"
 #include "core/layout/LayoutGeometryMap.h"
 #include "core/layout/LayoutPart.h"
 #include "core/layout/ViewFragmentationContext.h"
 #include "core/layout/api/LayoutAPIShim.h"
 #include "core/layout/api/LayoutPartItem.h"
 #include "core/layout/api/LayoutViewItem.h"
 #include "core/layout/compositing/PaintLayerCompositor.h"
 #include "core/page/Page.h"
 #include "core/paint/PaintLayer.h"
+#include "core/paint/ViewPaintInvalidator.h"
 #include "core/paint/ViewPainter.h"
 #include "core/svg/SVGDocumentExtensions.h"
 #include "platform/Histogram.h"
 #include "platform/geometry/FloatQuad.h"
 #include "platform/geometry/TransformState.h"
 #include "platform/graphics/paint/PaintController.h"
 #include "platform/instrumentation/tracing/TraceEvent.h"
 #include "platform/instrumentation/tracing/TracedValue.h"
 #include "public/platform/Platform.h"
 #include "wtf/PtrUtil.h"
-#include <inttypes.h>
 
 namespace blink {
 
 namespace {
 
 class HitTestLatencyRecorder {
  public:
   HitTestLatencyRecorder(bool allowsChildFrameContent)
       : m_start(WTF::monotonicallyIncreasingTime()),
         m_allowsChildFrameContent(allowsChildFrameContent) {}
@@ skipping 157 matching lines @@
         (heightChanged && mustInvalidateFillLayersPaintOnHeightChange(
                               style()->backgroundLayers())))
       setShouldDoFullPaintInvalidation(PaintInvalidationBoundsChange);
   }
 }
 
 void LayoutView::layout() {
   if (!document().paginated())
     setPageLogicalHeight(LayoutUnit());
 
+  // TODO(wangxianzhu): Move this into ViewPaintInvalidator when
+  // rootLayerScrolling is permanently enabled.
   IncludeScrollbarsInRect includeScrollbars =
       RuntimeEnabledFeatures::rootLayerScrollingEnabled() ? IncludeScrollbars
                                                           : ExcludeScrollbars;
   setShouldDoFullPaintInvalidationOnResizeIfNeeded(
       offsetWidth() != layoutSize(includeScrollbars).width(),
       offsetHeight() != layoutSize(includeScrollbars).height());
 
   if (pageLogicalHeight() && shouldUsePrintingLayout()) {
     m_minPreferredLogicalWidth = m_maxPreferredLogicalWidth = logicalWidth();
     if (!m_fragmentationContext) {
       m_fragmentationContext =
           WTF::wrapUnique(new ViewFragmentationContext(*this));
       m_paginationStateChanged = true;
     }
   } else if (m_fragmentationContext) {
     m_fragmentationContext.reset();
     m_paginationStateChanged = true;
   }
 
   SubtreeLayoutScope layoutScope(*this);
 
-  LayoutRect oldLayoutOverflowRect = layoutOverflowRect();
-
   // Use calcWidth/Height to get the new width/height, since this will take the
   // full page zoom factor into account.
   bool relayoutChildren =
       !shouldUsePrintingLayout() &&
       (!m_frameView || logicalWidth() != viewLogicalWidthForBoxSizing() ||
        logicalHeight() != viewLogicalHeightForBoxSizing());
   if (relayoutChildren) {
     layoutScope.setChildNeedsLayout(this);
     for (LayoutObject* child = firstChild(); child;
          child = child->nextSibling()) {
@@ skipping 14 matching lines @@
   }
 
   ASSERT(!m_layoutState);
   if (!needsLayout())
     return;
 
   LayoutState rootLayoutState(*this);
 
   layoutContent();
 
-  if (layoutOverflowRect() != oldLayoutOverflowRect) {
-    // The document element paints the viewport background, so we need to
-    // invalidate it when layout overflow changes.
-    // FIXME: Improve viewport background styling/invalidation/painting.
-    // crbug.com/475115
-    if (Element* documentElement = document().documentElement()) {
-      if (LayoutObject* rootObject = documentElement->layoutObject())
-        rootObject->setShouldDoFullPaintInvalidation();
-    }
-  }
-
 #if DCHECK_IS_ON()
   checkLayoutState();
 #endif
   clearNeedsLayout();
 }
 
 LayoutRect LayoutView::visualOverflowRect() const {
   // In root layer scrolling mode, the LayoutView performs overflow clipping
   // like a regular scrollable div.
   if (RuntimeEnabledFeatures::rootLayerScrollingEnabled())
@@ skipping 111 matching lines @@
 void LayoutView::computeSelfHitTestRects(Vector<LayoutRect>& rects,
                                          const LayoutPoint&) const {
   // Record the entire size of the contents of the frame. Note that we don't
   // just use the viewport size (containing block) here because we want to
   // ensure this includes all children (so we can avoid walking them
   // explicitly).
   rects.push_back(
       LayoutRect(LayoutPoint::zero(), LayoutSize(frameView()->contentsSize())));
 }
 
+PaintInvalidationReason LayoutView::invalidatePaintIfNeeded(
+    const PaintInvalidationState& paintInvalidationState) {
+  return LayoutBlockFlow::invalidatePaintIfNeeded(paintInvalidationState);
+}
+
+PaintInvalidationReason LayoutView::invalidatePaintIfNeeded(
+    const PaintInvalidatorContext& context) const {
+  return ViewPaintInvalidator(*this, context).invalidatePaintIfNeeded();
+}
+
 void LayoutView::paint(const PaintInfo& paintInfo,
                        const LayoutPoint& paintOffset) const {
   ViewPainter(*this).paint(paintInfo, paintOffset);
 }
 
 void LayoutView::paintBoxDecorationBackground(const PaintInfo& paintInfo,
                                               const LayoutPoint&) const {
   ViewPainter(*this).paintBoxDecorationBackground(paintInfo);
 }
 
@@ skipping 611 matching lines @@
 bool LayoutView::paintedOutputOfObjectHasNoEffectRegardlessOfSize() const {
   // Frame scroll corner is painted using LayoutView as the display item client.
   if (!RuntimeEnabledFeatures::rootLayerScrollingEnabled() &&
       (frameView()->horizontalScrollbar() || frameView()->verticalScrollbar()))
     return false;
 
   return LayoutBlockFlow::paintedOutputOfObjectHasNoEffectRegardlessOfSize();
 }
 
 }  // namespace blink