Add android_library template

build/android/gyp/util/build_utils.py

 # Copyright 2013 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
+import ast
 import fnmatch
 import json
 import os
 import pipes
 import shlex
 import shutil
 import subprocess
 import sys
+import tempfile
+import traceback
 

[Nico, 2014/05/05 22:08:10]

nit: 2 newlines between toplevels

[cjhopman, 2014/06/25 01:20:03]

Done.

+class TempDir(object):
+  def __init__(self):
+    self.dir = tempfile.mkdtemp()
+
+  def __enter__(self):
+    return self.dir
+
+  def __exit__(self, type, value, traceback):
+    shutil.rmtree(self.dir)

[Nico, 2014/05/05 22:08:10]

nit: Maybe:

@contextmanager
def TempDir():
  dir = tempfile.mkdtemp()
  try:
    yield dir
  finally:
    shutil.rmtree(dir)

is a tad simpler (9_9 at the library version of TemporaryDirectory requiring
3.2)

[cjhopman, 2014/06/25 01:20:03]

Done.

[Nico, 2014/05/05 22:08:10]

nit: 2 newlines between toplevels

[cjhopman, 2014/06/25 01:20:03]

Done.

 def MakeDirectory(dir_path):
   try:
     os.makedirs(dir_path)
   except OSError:
     pass
 
 
 def DeleteDirectory(dir_path):
   if os.path.exists(dir_path):
     shutil.rmtree(dir_path)
 
 
-def Touch(path):
+def Touch(path, fail_if_missing=False):
+  if fail_if_missing and not os.path.exists(path):
+    raise Exception(path + ' doesn\'t exist.')
+
   MakeDirectory(os.path.dirname(path))
   with open(path, 'a'):
     os.utime(path, None)
 
 
 def FindInDirectory(directory, filename_filter):
   files = []
   for root, _dirnames, filenames in os.walk(directory):
     matched_files = fnmatch.filter(filenames, filename_filter)
     files.extend((os.path.join(root, f) for f in matched_files))
   return files
 
 
 def FindInDirectories(directories, filename_filter):
   all_files = []
   for directory in directories:
     all_files.extend(FindInDirectory(directory, filename_filter))
   return all_files
 
 
+def ParseGnList(gn_string):
+  return ast.literal_eval(gn_string)
+
+
 def ParseGypList(gyp_string):
   # The ninja generator doesn't support $ in strings, so use ## to
   # represent $.
   # TODO(cjhopman): Remove when
   # https://code.google.com/p/gyp/issues/detail?id=327
   # is addressed.
   gyp_string = gyp_string.replace('##', '$')
   return shlex.split(gyp_string)
 
 
@@ skipping 85 matching lines @@
 
 
 def PrintWarning(message):
   print 'WARNING: ' + message
 
 
 def PrintBigWarning(message):
   print '*****     ' * 8
   PrintWarning(message)
   print '*****     ' * 8
+

[Nico, 2014/05/05 22:08:10]

nit: 2 newlines

[cjhopman, 2014/06/25 01:20:03]

Done.

+def GetPythonDependencies():

[Nico, 2014/05/05 22:08:10]

docstring

[cjhopman, 2014/06/25 01:20:03]

Done.

+  module_paths = (m.__file__ for m in sys.modules.itervalues()
+                  if m is not None and hasattr(m, '__file__'))
+
+  abs_module_paths = map(os.path.abspath, module_paths)
+
+  chromium_src = os.path.abspath(
+      os.path.join(__file__, '..', '..', '..', '..'))

[Nico, 2014/05/05 22:08:10]

Can you put this in a constant at the top of the file? Or can you even use the
existing constant in build/android/common.py (iirc)?

[cjhopman, 2014/06/25 01:20:03]

Done.

+
+  non_system_module_paths = [p for p in abs_module_paths if p.startswith(chromium_src)]

[Nico, 2014/05/05 22:08:10]

nit: 80 cols

[cjhopman, 2014/06/25 01:20:03]

Done.

+  def ConvertPycToPy(s):
+    if s.endswith('.pyc'):
+      return s[:-1]
+    return s
+
+  non_system_module_paths = map(ConvertPycToPy, non_system_module_paths)
+  return list(set(non_system_module_paths))

[Nico, 2014/05/05 22:08:10]

Huh, so these are all absolute paths? Can we make them relative, maybe?

[cjhopman, 2014/06/25 01:20:03]

Done.

+

[Nico, 2014/05/05 22:08:10]

2 newlines

[cjhopman, 2014/06/25 01:20:03]

Done.

+def WriteDepfile(path, dependencies):
+  with open(path, 'w') as depfile:
+    depfile.write(path)
+    depfile.write(': ')
+    depfile.write(' '.join(dependencies))
+    depfile.write('\n')