Add android_library template

build/android/gn/javac.py

+#!/usr/bin/env python

[cjhopman, 2014/06/25 01:20:03]

This now uses the gyp/javac.py (going forward, we won't write separate scripts
for gyp/gn).

+#
+# Copyright 2014 The Chromium Authors. All rights reserved.
+# Use of this source code is governed by a BSD-style license that can be
+# found in the LICENSE file.
+
+import fnmatch
+import optparse
+import os
+import sys
+import zipfile
+
+BUILD_ANDROID_DIR = os.path.join(os.path.dirname(__file__), '..')
+sys.path.append(BUILD_ANDROID_DIR)

[Nico, 2014/05/05 22:26:14]

This is defined in build/android/pylib/constants.py too

[cjhopman, 2014/06/25 01:20:03]

Can't access constants.py without first calculating this path.

+
+from gyp import javac as gyp_javac
+from gyp import jar as gyp_jar
+from gyp.util import build_utils
+
+
+def main(argv):
+  parser = optparse.OptionParser()
+  parser.add_option(
+      '--depfile',
+      help='Path to depfile output (relative to the root build directory).')
+  parser.add_option('--java-files', help='List of java files to compile.')
+  parser.add_option(
+      '--java-srcjars',
+      help='List of srcjars to include in compilation.')
+  parser.add_option('--classpath-jars', help='Paths to jar dependencies.')
+  parser.add_option('--jar-path', help='Output jar path.')
+  parser.add_option('--chromium-code', help='If 1, enable extra warnings.')
+  options, _ = parser.parse_args(argv)
+
+  build_utils.WriteDepfile(options.depfile,

[Nico, 2014/05/05 21:56:45]

I don't see this checked in yet. Does this have the right base directory?
(depfile entries are relative to the build directory, while
GetPythonDependencies() probably returns paths relative to the source root)

[cjhopman, 2014/05/05 22:05:19]

This is in build/android/gyp/util/build_utils.py
It returns absolute paths (which seem to work correctly).

+                           build_utils.GetPythonDependencies())
+
+  java_files = build_utils.ParseGnList(options.java_files)

[Nico, 2014/05/05 22:26:14]

nit: I'd parse java_files through args, not through a flag. java files are the
main arguments for a script that compiles java files.

[cjhopman, 2014/06/25 01:20:03]

Done.

+  java_srcjars = build_utils.ParseGnList(options.java_srcjars)
+  classpath_jars = build_utils.ParseGnList(options.classpath_jars)
+  jar_path = options.jar_path
+  chromium_code = options.chromium_code == 'false'

[Nico, 2014/05/05 22:26:14]

Make the option's action store_bool instead?

[cjhopman, 2014/06/25 01:20:02]

Done. It is complicated to have gyp use options that have action store_bool, so
something like what this had before is not uncommon in these scripts.

+
+  with build_utils.TempDir() as temp_dir:
+    classes_dir = os.path.join(temp_dir, 'classes')

[Nico, 2014/05/05 22:26:14]

Consider giving TempDir() an argument that's appended the the tempdir path. It
feels this would be useful often.

+    os.makedirs(classes_dir)
+    if java_srcjars:
+      java_dir = os.path.join(temp_dir, 'java')
+      os.makedirs(java_dir)
+      for srcjar in java_srcjars:
+        with zipfile.ZipFile(srcjar, 'r') as srczip:
+          for name in srczip.namelist():
+            if os.path.normpath(name) != name:
+              raise Exception('bad name in srcjar')
+            srczip.extract(name, java_dir)
+            java_files.append(os.path.join(java_dir, name))

[Nico, 2014/05/05 22:26:14]

This is a somewhat "interesting" change. I'd decouple it from the gn bits – if
you think this is a good change, this can be done in both builds, right? (Maybe
I missed something gn-specific about this.)

[cjhopman, 2014/06/25 01:20:03]

In general, I think this is a much better approach than passing around
directories of files (particularly in gn where we create these srcjars with an
explicit list of files and not just zipping a full directory).

I think that one of the common cases where we generate java files uses a 'rules'
block in gyp. Gyp doesn't provide a way to get the outputs of a rule, and so it
is difficult to zip the outputs together (it either has to be done in two
separate targets, or you need to hardcode in the paths to the outputs).

In GN, the same case is easy because you have access to the outputs of an
action_foreach (and if you only want some of the outputs you can construct them
with the same pattern construction techniques as the outputs of the
action_foreach are constructed).

+
+
+    gyp_javac.Javac(java_files, classpath_jars, classes_dir, chromium_code)
+    class_files = build_utils.FindInDirectory(classes_dir, '*.class')
+    gyp_jar.Jar(class_files, classes_dir, jar_path)
+
+
+
+if __name__ == '__main__':
+  sys.exit(main(sys.argv))
+

[Nico, 2014/05/05 21:56:45]

nit: Maybe have fewer than 4 empty newlines at the end of the file :-)

[cjhopman, 2014/05/05 22:05:19]

Ha.

+
+
+