Remove base version of GetCanonicalLocale() function.

Remove base version of GetCanonicalLocale() function.

Instead have the GetCanonicalLocale() function from l10n_util call
base::i18n::GetLocaleString(), which had to be exposed in the header, so
it could be called from l10n_util.

BUG=None
TEST=None
R=jshin@chromium.org,tony@chromium.org

[tfarina, 2014-05-05 17:54:32]

https://codereview.chromium.org/269943004/diff/1/base/i18n/rtl.h
File base/i18n/rtl.h (right):

https://codereview.chromium.org/269943004/diff/1/base/i18n/rtl.h#newcode14
base/i18n/rtl.h:14: #include "third_party/icu/source/common/unicode/locid.h"
I was not able to do:

namespace icu {
class Locale;
}

It gave me an error about redefinition or something :/

[tony, 2014-05-05 18:06:09]

Looks like a you need to add a dependency to base to get this to compile.

On 2014/05/05 17:54:32, tfarina wrote:
> https://codereview.chromium.org/269943004/diff/1/base/i18n/rtl.h
> File base/i18n/rtl.h (right):
> 
> https://codereview.chromium.org/269943004/diff/1/base/i18n/rtl.h#newcode14
> base/i18n/rtl.h:14: #include "third_party/icu/source/common/unicode/locid.h"
> I was not able to do:
> 
> namespace icu {
> class Locale;
> }
> 
> It gave me an error about redefinition or something :/

What's the exact error?

[tfarina, 2014-05-05 18:40:39]

On 2014/05/05 18:06:09, tony wrote:
> Looks like a you need to add a dependency to base to get this to compile.
> 
> On 2014/05/05 17:54:32, tfarina wrote:
> > https://codereview.chromium.org/269943004/diff/1/base/i18n/rtl.h
> > File base/i18n/rtl.h (right):
> > 
> > https://codereview.chromium.org/269943004/diff/1/base/i18n/rtl.h#newcode14
> > base/i18n/rtl.h:14: #include "third_party/icu/source/common/unicode/locid.h"
> > I was not able to do:
> > 
> > namespace icu {
> > class Locale;
> > }
> > 
> > It gave me an error about redefinition or something :/
> 
> What's the exact error?

In file included from ../../base/i18n/rtl.cc:12:
In file included from ../../third_party/icu/source/common/unicode/locid.h:32:
In file included from ../../third_party/icu/source/common/unicode/utypes.h:38:
../../third_party/icu/source/common/unicode/uversion.h:110:19: error:
redefinition of 'icu'
        namespace icu = U_ICU_NAMESPACE;
                  ^
../../base/i18n/rtl.h:15:11: note: previous definition is here
namespace icu {
          ^
../../base/i18n/rtl.cc:50:32: error: member access into incomplete type 'const
icu::Locale'
  const char* language = locale.getLanguage();
                               ^
../../base/i18n/rtl.h:16:7: note: forward declaration of 'icu::Locale'
class Locale;
      ^

[jungshik at Google, 2014-05-05 21:49:22]

https://codereview.chromium.org/269943004/diff/1/base/i18n/rtl.h
File base/i18n/rtl.h (right):

https://codereview.chromium.org/269943004/diff/1/base/i18n/rtl.h#newcode14
base/i18n/rtl.h:14: #include "third_party/icu/source/common/unicode/locid.h"
On 2014/05/05 17:54:32, tfarina wrote:
> I was not able to do:
> 
> namespace icu {
> class Locale;
> }
> 
> It gave me an error about redefinition or something :/

What happens if you try 'namespace icu46'? Not that I want you to do that, but
....

[jungshik at Google, 2014-05-05 22:08:26]

On 2014/05/05 21:49:22, Jungshik Shin wrote:
> https://codereview.chromium.org/269943004/diff/1/base/i18n/rtl.h
> File base/i18n/rtl.h (right):
> 
> https://codereview.chromium.org/269943004/diff/1/base/i18n/rtl.h#newcode14
> base/i18n/rtl.h:14: #include "third_party/icu/source/common/unicode/locid.h"
> On 2014/05/05 17:54:32, tfarina wrote:
> > I was not able to do:
> > 
> > namespace icu {
> > class Locale;
> > }
> > 
> > It gave me an error about redefinition or something :/
> 
> What happens if you try 'namespace icu46'? Not that I want you to do that, but
> ....

Better, what happens if you set 'U_DISABLE_RENAMING' to 1 in icu.gyp and
rebuild?

[tfarina, 2014-05-06 16:00:38]

On 2014/05/05 22:08:26, Jungshik Shin wrote:
> On 2014/05/05 21:49:22, Jungshik Shin wrote:
> > https://codereview.chromium.org/269943004/diff/1/base/i18n/rtl.h
> > File base/i18n/rtl.h (right):
> > 
> > https://codereview.chromium.org/269943004/diff/1/base/i18n/rtl.h#newcode14
> > base/i18n/rtl.h:14: #include "third_party/icu/source/common/unicode/locid.h"
> > On 2014/05/05 17:54:32, tfarina wrote:
> > > I was not able to do:
> > > 
> > > namespace icu {
> > > class Locale;
> > > }
> > > 
> > > It gave me an error about redefinition or something :/
> > 
> > What happens if you try 'namespace icu46'? Not that I want you to do that,
but
> > ....
> 
> Better, what happens if you set 'U_DISABLE_RENAMING' to 1 in icu.gyp and
> rebuild?

It works! yay. But too bad, icu.gyp is not in the chromium three. It is part of
the icu tree. And thus the changes to icu.gyp does not show up in patch set 3.

[tfarina, 2014-05-07 04:14:46]

On 2014/05/06 16:00:38, tfarina wrote:
> On 2014/05/05 22:08:26, Jungshik Shin wrote:
> > On 2014/05/05 21:49:22, Jungshik Shin wrote:
> > > https://codereview.chromium.org/269943004/diff/1/base/i18n/rtl.h
> > > File base/i18n/rtl.h (right):
> > > 
> > > https://codereview.chromium.org/269943004/diff/1/base/i18n/rtl.h#newcode14
> > > base/i18n/rtl.h:14: #include
"third_party/icu/source/common/unicode/locid.h"
> > > On 2014/05/05 17:54:32, tfarina wrote:
> > > > I was not able to do:
> > > > 
> > > > namespace icu {
> > > > class Locale;
> > > > }
> > > > 
> > > > It gave me an error about redefinition or something :/
> > > 
> > > What happens if you try 'namespace icu46'? Not that I want you to do that,
> but
> > > ....
> > 
> > Better, what happens if you set 'U_DISABLE_RENAMING' to 1 in icu.gyp and
> > rebuild?
> 
> It works! yay. But too bad, icu.gyp is not in the chromium three. It is part
of
> the icu tree. And thus the changes to icu.gyp does not show up in patch set 3.

I followed the instructions from
http://www.chromium.org/developers/how-tos/get-the-code#TOC-Working-with-repo...,
then I ran git cl config, git co -b foo, commit, git cl upload.

The CL for the icu.gyp change is here ->
https://codereview.chromium.org/270603002

Is that the way to change it?

[tfarina, 2014-05-15 22:47:08]

Tony, Jungshik, while https://codereview.chromium.org/270603002 is on hold, can
we go with including third_party/icu/source/common/unicode/locid.h in rtl.h with
a TODO to forward declare it after ICU is rolled to 52?

(There is no pressure, I know, it is just I don't like to have things
unfinished).

[tfarina, 2014-09-08 02:35:20]

Ping.

https://codereview.chromium.org/269943004/diff/30001/base/i18n/rtl.h
File base/i18n/rtl.h (right):

https://codereview.chromium.org/269943004/diff/30001/base/i18n/rtl.h#newcode15
base/i18n/rtl.h:15: namespace icu {
forward declaring this namespace does not work in the icu_52 world either.

OK to include locid.h here?

[tfarina, 2015-01-12 21:38:48]

I redo this in https://codereview.chromium.org/834183005/.

Closing this.