Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(268)

Unified Diff: third_party/WebKit/Source/core/layout/line/InlineFlowBox.cpp

Issue 2699393002: Place ellipsis correctly inside inline-blocks (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/layout/line/InlineFlowBox.cpp
diff --git a/third_party/WebKit/Source/core/layout/line/InlineFlowBox.cpp b/third_party/WebKit/Source/core/layout/line/InlineFlowBox.cpp
index 050b9bd5f67f68a1e748f62a989c267ec7fe7110..4e0cb59a8b80f6fa3292c701287ef0c5c37adb66 100644
--- a/third_party/WebKit/Source/core/layout/line/InlineFlowBox.cpp
+++ b/third_party/WebKit/Source/core/layout/line/InlineFlowBox.cpp
@@ -1423,7 +1423,8 @@ LayoutUnit InlineFlowBox::placeEllipsisBox(bool ltr,
LayoutUnit blockRightEdge,
LayoutUnit ellipsisWidth,
LayoutUnit& truncatedWidth,
- bool& foundBox) {
+ bool& foundBox,
+ LayoutUnit logicalLeftOffset) {
LayoutUnit result(-1);
// We iterate over all children, the foundBox variable tells us when we've
// found the box containing the ellipsis. All boxes after that one in the
@@ -1439,8 +1440,8 @@ LayoutUnit InlineFlowBox::placeEllipsisBox(bool ltr,
while (box) {
LayoutUnit currResult = box->placeEllipsisBox(
- ltr, LayoutUnit(visibleLeftEdge), LayoutUnit(visibleRightEdge),
- ellipsisWidth, truncatedWidth, foundBox);
+ ltr, visibleLeftEdge, visibleRightEdge, ellipsisWidth, truncatedWidth,
+ foundBox, logicalLeftOffset);
if (currResult != -1 && result == -1)
result = currResult;

Powered by Google App Engine
This is Rietveld 408576698