Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(100)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 269933002: Restore building crash_service on win builder bot (Closed)

Created:
6 years, 7 months ago by loislo
Modified:
6 years, 7 months ago
Reviewers:
falken, Nate Chapin
CC:
chromium-reviews
Visibility:
Public.

Description

Restore building crash_service on win builder bot BUG=369029 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=268344

Patch Set 1 #

Patch Set 2 : unnecessary check was removed #

Patch Set 3 : syntax error was fixed #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -0 lines) Patch
M build/all.gyp View 1 2 2 chunks +8 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
loislo
6 years, 7 months ago (2014-05-05 15:20:32 UTC) #1
Nate Chapin
lgtm
6 years, 7 months ago (2014-05-05 15:59:29 UTC) #2
loislo
The CQ bit was checked by loislo@chromium.org
6 years, 7 months ago (2014-05-05 16:16:43 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/loislo@chromium.org/269933002/40001
6 years, 7 months ago (2014-05-05 16:16:54 UTC) #4
commit-bot: I haz the power
6 years, 7 months ago (2014-05-06 00:46:55 UTC) #5
Message was sent while issue was closed. 
Change committed as 268344

Powered by Google App Engine
This is Rietveld 408576698