chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationConstants.java - Issue 2699253003: Abstracting over Notification.Builder + NotificationCompat.Builder

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationConstants.java

Issue 2699253003: Abstracting over Notification.Builder + NotificationCompat.Builder (Closed)

Patch Set: Abstracting over Notification.Builder + NotificationCompat.Builder Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationBuilder.java ('K') | « chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationCompatBuilder.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/ntp/ContentSuggestionsNotificationHelper.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationConstants.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationConstants.java b/chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationConstants.java

index 366cb54213206ffa2d8a6cceff00616729325fef..a1e01feb0fed3f109edab934cdf027c9a238c0ba 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationConstants.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationConstants.java

@@ -77,4 +77,11 @@ public class NotificationConstants {

// Web notification group names are set dynamically as this prefix + notification origin.

// For example, 'Web:chromium.org' for a notification from chromium.org.

static final String GROUP_WEB_PREFIX = "Web:";

+ public static final String TYPE_ID_GENERAL = "general";

+ public static final String TYPE_NAME_GENERAL = "General"; // TODO Define this in GRD not here

+ public static final String TYPE_ID_INCOGNITO = "incognito";

+ public static final String TYPE_NAME_INCOGNITO =

+ "Incognito"; // TODO Define this in GRD not here

Peter Beverloo 2017/02/20 01:06:45 We should fulfil these TODOs in this CL.

awdf 2017/02/24 00:38:47 Done. (Added 'General' string to grd file, removed

}