Abstracting over Notification.Builder + NotificationCompat.Builder

chrome/android/java/src/org/chromium/chrome/browser/ChromeApplication.java

Index: chrome/android/java/src/org/chromium/chrome/browser/ChromeApplication.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ChromeApplication.java b/chrome/android/java/src/org/chromium/chrome/browser/ChromeApplication.java
index 17120e871caffbdcfa4cbda7b11184ede7e02aff..e3e7721161599d77b188d64b478055724b7903b5 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/ChromeApplication.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/ChromeApplication.java
@@ -41,6 +41,9 @@ import org.chromium.chrome.browser.metrics.UmaUtils;
 import org.chromium.chrome.browser.metrics.VariationsSession;
 import org.chromium.chrome.browser.multiwindow.MultiWindowUtils;
 import org.chromium.chrome.browser.net.qualityprovider.ExternalEstimateProviderAndroid;
+import org.chromium.chrome.browser.notifications.ChromeNotificationBuilder;
+import org.chromium.chrome.browser.notifications.NotificationBuilder;
+import org.chromium.chrome.browser.notifications.NotificationCompatBuilder;
 import org.chromium.chrome.browser.omaha.RequestGenerator;
 import org.chromium.chrome.browser.partnercustomizations.PartnerBrowserCustomizations;
 import org.chromium.chrome.browser.physicalweb.PhysicalWebBleClient;
@@ -428,4 +431,9 @@ public class ChromeApplication extends ContentApplication {
     public AccountManagerDelegate createAccountManagerDelegate() {
         return new SystemAccountManagerDelegate(this);
     }
+

[Peter Beverloo, 2017/02/20 01:06:45]

docs++

Maybe add a TODO at the same time that we can delete this in Chrome 59?

[awdf, 2017/02/24 00:38:46]

Done.

+    public ChromeNotificationBuilder getChromeNotificationBuilder(

[nyquist, 2017/02/22 10:43:59]

Also, could we change this to create? We seem to be creating the builder for
each call.

[awdf, 2017/02/24 00:38:46]

Done.

+            boolean preferCompat, String typeId, String typeName) {
+        return preferCompat ? new NotificationCompatBuilder(this) : new NotificationBuilder(this);
+    }
 }