Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1159)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/ChromeApplication.java

Issue 2699253003: Abstracting over Notification.Builder + NotificationCompat.Builder (Closed)
Patch Set: Responding to comments Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/ChromeApplication.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ChromeApplication.java b/chrome/android/java/src/org/chromium/chrome/browser/ChromeApplication.java
index b773d254a1ff1bf7a2635cbc76946e6541822a16..da2f3ae419b2aeb21bcb5369148adc93565e3374 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/ChromeApplication.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/ChromeApplication.java
@@ -43,6 +43,9 @@ import org.chromium.chrome.browser.metrics.UmaUtils;
import org.chromium.chrome.browser.metrics.VariationsSession;
import org.chromium.chrome.browser.multiwindow.MultiWindowUtils;
import org.chromium.chrome.browser.net.qualityprovider.ExternalEstimateProviderAndroid;
+import org.chromium.chrome.browser.notifications.ChromeNotificationBuilder;
+import org.chromium.chrome.browser.notifications.NotificationBuilder;
+import org.chromium.chrome.browser.notifications.NotificationCompatBuilder;
import org.chromium.chrome.browser.omaha.RequestGenerator;
import org.chromium.chrome.browser.partnercustomizations.PartnerBrowserCustomizations;
import org.chromium.chrome.browser.physicalweb.PhysicalWebBleClient;
@@ -461,4 +464,17 @@ public class ChromeApplication extends ContentApplication {
// {@link android.app.Service#startForeground(int, Notification)}.
startService(intent);
}
+
+ /**
+ * Creates either a Notification.Builder or NotificationCompat.Builder under the hood, wrapped
+ * in our own common interface. Should be used for all notifications we create.
+ *
+ * TODO(awdf) Remove this once we've updated to revision 26 of the support library.
+ *
+ * @param preferCompat if a NotificationCompat.Builder is preferred.
+ */
+ public ChromeNotificationBuilder createChromeNotificationBuilder(
+ boolean preferCompat, String notificationCategoryId, String notificationCategoryName) {
+ return preferCompat ? new NotificationCompatBuilder(this) : new NotificationBuilder(this);
+ }
}

Powered by Google App Engine
This is Rietveld 408576698